Investigate the idea of a remote git #58
Conversation
|
I'm going to be listing some of the "local" filesystem assumptions being made in Elastic-Git currently here.
|
|
Not remotely read for review. |
|
@Rizziepit & @miltontony ready for initial review. Still need to implement |
|
Oh wait, it was already implemented in |
|
@Rizziepit & @miltontony ready for review. |
|
Uh, no wait, haven't made it hook up to EG yet. |
|
|
||
| def store(self, model, message, author=None, committer=None): | ||
| raise RemoteStorageException( | ||
| 'Remote storage is read only.') |
There was a problem hiding this comment.
Is this for now or indefinitely?
There was a problem hiding this comment.
For now. At some point we may want to write to the API, depends on which direction things go.
|
Seems to be working. |
|
@Rizziepit & @miltontony can I get a review please? |
|
+1 |
|
@Rizziepit please review the last commit, it adds the |
| import warnings | ||
| warnings.warn('Pulling without updating the index!') | ||
| self.sm.pull(branch_name=branch_name, | ||
| remote_name=remote_name) |
There was a problem hiding this comment.
universalcore/unicore.distribute#18 addresses this and will implement in a different PR.
|
Looks good. Should EG have a method to create a remote workspace? Might have missed it. |
|
@Rizziepit I considered it but |
|
Makes sense. All the +1 from me |
The idea is to see if we can combine
unicore.distributeinto a server endpoint for all git + elasticsearch related operations that elasticgit may want to do on a remote server.