fix: move prettier-ignore statement so it works
#729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
HookyGV
commented
Jan 20, 2024
| @@ -114,20 +114,14 @@ export function getDeclaration(ctx: Context, filepath: string, originalImports?: | |||
| directive: stringifyDeclarationImports({ ...originalImports?.directive, ...imports.directive }), | |||
| } | |||
|
|
|||
| const head = ctx.options.version === 2.7 | |||
There was a problem hiding this comment.
Note that both paths here resolve to the same string, so this check is no longer required.
HookyGV
changed the title
prettier-ignore statement so it works
antfu
changed the title
prettier-ignore statement so it worksprettier-ignore statement so it works
antfu
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solve the prettier formatting issue, but leave the comment in the head section.
prettier-ignorewill ignore following block (the module declaration) in this case.See https://prettier.io/docs/en/ignore.html#javascript
Linked Issues
Same issue, different solution: PR #689
Additional context