Skip to content

chore: fix 'publicly accessible' wording #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

TylerGillson
Copy link
Member

Issue

Resolves #240

Description

Reword misleading usages of the term 'publicly accessible'.

@TylerGillson TylerGillson requested a review from a team as a code owner August 6, 2024 22:18
@TylerGillson TylerGillson requested a review from ahmad-ibra August 6, 2024 22:18
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. documentation Improvements or additions to documentation labels Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff           @@
##             main     #242   +/-   ##
=======================================
  Coverage   39.63%   39.63%           
=======================================
  Files           7        7           
  Lines         381      381           
=======================================
  Hits          151      151           
  Misses        216      216           
  Partials       14       14           
Files Coverage Δ
api/v1alpha1/networkvalidator_types.go 80.64% <ø> (ø)
pkg/network/network.go 23.40% <100.00%> (ø)
pkg/secrets/secrets.go 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 574776b...d29367c. Read the comment docs.

@TylerGillson TylerGillson merged commit 9dbb6a7 into main Aug 6, 2024
8 checks passed
@TylerGillson TylerGillson deleted the chore/wording branch August 6, 2024 23:18
ahmad-ibra pushed a commit that referenced this pull request Aug 12, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.0.23](v0.0.22...v0.0.23)
(2024-08-12)


### Other

* fix 'publicly accessible' wording
([#242](#242))
([9dbb6a7](9dbb6a7))
* satisfy ValidationRule
([#246](#246))
([18ffc3b](18ffc3b))


### Dependency Updates

* **deps:** update module github.com/onsi/ginkgo/v2 to v2.20.0
([#245](#245))
([679cf0c](679cf0c))
* **deps:** update module github.com/validator-labs/validator to v0.1.3
([#238](#238))
([1724a4e](1724a4e))
* **deps:** update module sigs.k8s.io/cluster-api to v1.8.0
([#247](#247))
([7885320](7885320))
* **deps:** update module sigs.k8s.io/controller-runtime to v0.18.5
([#248](#248))
([66f3e36](66f3e36))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🌱 Reword "publicly available" in validation result details to "verified"
1 participant