Skip to content

validator to check if strong password exists #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

MohakChugh
Copy link

A new Validator which checks if the password provided is a strong password or not.
A password is a strong password is it contains :

  1. Capital Letter (at least 1)
  2. Small Letter (at least 1)
  3. Number (at least 1)
  4. Special Character (at least 1)
  5. Length (ateast 4)

@profnandaa
Copy link
Member

Please clean up this PR to only include the relevant files needed for the feature work.

@profnandaa profnandaa added the 🧹 needs-update For PRs that need to be updated before landing label Oct 13, 2019
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @MohakChugh , i suggest you to read Contributing guidelines

  • You pushed a .history folder with 131 files, you need to delete that folder
  • You added your changes to /lib folder which is autogenerated, you need instead to use src/lib
  • You need to add tests to your changes and a section in README.md if you are adding a new validator

@gayathrigs27
Copy link

#1148

@MohakChugh
Copy link
Author

I removed the History and Deleted the file from lib folder. Sorry for not following the guidelines earlier

@profnandaa
Copy link
Member

Can fix the merge conflicts?

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please redo this PR afresh, looks like to removed the important source file.

@profnandaa
Copy link
Member

closing for #1148

@profnandaa profnandaa closed this Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 needs-update For PRs that need to be updated before landing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants