-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat: implement isIBAN(str) validator #1243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,145 @@ | ||
"use strict"; | ||
|
||
Object.defineProperty(exports, "__esModule", { | ||
value: true | ||
}); | ||
exports.default = isIBAN; | ||
|
||
var _assertString = _interopRequireDefault(require("./util/assertString")); | ||
|
||
function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; } | ||
|
||
/** | ||
* List of country codes with | ||
* corresponding IBAN regular expression | ||
* Reference: https://en.wikipedia.org/wiki/International_Bank_Account_Number | ||
*/ | ||
var ibanRegexThroughCountryCode = { | ||
AD: /^(AD[0-9]{2})\d{8}[A-Z0-9]{12}$/, | ||
AE: /^(AE[0-9]{2})\d{3}\d{16}$/, | ||
AL: /^(AL[0-9]{2})\d{8}[A-Z0-9]{16}$/, | ||
AT: /^(AT[0-9]{2})\d{16}$/, | ||
AZ: /^(AZ[0-9]{2})[A-Z0-9]{4}\d{20}$/, | ||
BA: /^(BA[0-9]{2})\d{16}$/, | ||
BE: /^(BE[0-9]{2})\d{12}$/, | ||
BG: /^(BG[0-9]{2})[A-Z]{4}\d{6}[A-Z0-9]{8}$/, | ||
BH: /^(BH[0-9]{2})[A-Z]{4}[A-Z0-9]{14}$/, | ||
BR: /^(BR[0-9]{2})\d{23}[A-Z]{1}[A-Z0-9]{1}$/, | ||
BY: /^(BY[0-9]{2})[A-Z0-9]{4}\d{20}$/, | ||
CH: /^(CH[0-9]{2})\d{5}[A-Z0-9]{12}$/, | ||
CR: /^(CR[0-9]{2})\d{18}$/, | ||
CY: /^(CY[0-9]{2})\d{8}[A-Z0-9]{16}$/, | ||
CZ: /^(CZ[0-9]{2})\d{20}$/, | ||
DE: /^(DE[0-9]{2})\d{18}$/, | ||
DK: /^(DK[0-9]{2})\d{14}$/, | ||
DO: /^(DO[0-9]{2})[A-Z]{4}\d{20}$/, | ||
EE: /^(EE[0-9]{2})\d{16}$/, | ||
ES: /^(ES[0-9]{2})\d{20}$/, | ||
FI: /^(FI[0-9]{2})\d{14}$/, | ||
FO: /^(FO[0-9]{2})\d{14}$/, | ||
FR: /^(FR[0-9]{2})\d{10}[A-Z0-9]{11}\d{2}$/, | ||
GB: /^(GB[0-9]{2})[A-Z]{4}\d{14}$/, | ||
GE: /^(GE[0-9]{2})[A-Z0-9]{2}\d{16}$/, | ||
GI: /^(GI[0-9]{2})[A-Z]{4}[A-Z0-9]{15}$/, | ||
GL: /^(GL[0-9]{2})\d{14}$/, | ||
GR: /^(GR[0-9]{2})\d{7}[A-Z0-9]{16}$/, | ||
GT: /^(GT[0-9]{2})[A-Z0-9]{4}[A-Z0-9]{20}$/, | ||
HR: /^(HR[0-9]{2})\d{17}$/, | ||
HU: /^(HU[0-9]{2})\d{24}$/, | ||
IE: /^(IE[0-9]{2})[A-Z0-9]{4}\d{14}$/, | ||
IL: /^(IL[0-9]{2})\d{19}$/, | ||
IQ: /^(IQ[0-9]{2})[A-Z]{4}\d{15}$/, | ||
IS: /^(IS[0-9]{2})\d{22}$/, | ||
IT: /^(IT[0-9]{2})[A-Z]{1}\d{10}[A-Z0-9]{12}$/, | ||
JO: /^(JO[0-9]{2})[A-Z]{4}\d{22}$/, | ||
KW: /^(KW[0-9]{2})[A-Z]{4}[A-Z0-9]{22}$/, | ||
KZ: /^(KZ[0-9]{2})\d{3}[A-Z0-9]{13}$/, | ||
LB: /^(LB[0-9]{2})\d{4}[A-Z0-9]{20}$/, | ||
LC: /^(LC[0-9]{2})[A-Z]{4}[A-Z0-9]{24}$/, | ||
LI: /^(LI[0-9]{2})\d{5}[A-Z0-9]{12}$/, | ||
LT: /^(LT[0-9]{2})\d{16}$/, | ||
LU: /^(LU[0-9]{2})\d{3}[A-Z0-9]{13}$/, | ||
LV: /^(LV[0-9]{2})[A-Z]{4}[A-Z0-9]{13}$/, | ||
MC: /^(MC[0-9]{2})\d{10}[A-Z0-9]{11}\d{2}$/, | ||
MD: /^(MD[0-9]{2})[A-Z0-9]{20}$/, | ||
ME: /^(ME[0-9]{2})\d{18}$/, | ||
MK: /^(MK[0-9]{2})\d{3}[A-Z0-9]{10}\d{2}$/, | ||
MR: /^(MR[0-9]{2})\d{23}$/, | ||
MT: /^(MT[0-9]{2})[A-Z]{4}\d{5}[A-Z0-9]{18}$/, | ||
MU: /^(MU[0-9]{2})[A-Z]{4}\d{19}[A-Z]{3}$/, | ||
NL: /^(NL[0-9]{2})[A-Z]{4}\d{10}$/, | ||
NO: /^(NO[0-9]{2})\d{11}$/, | ||
PK: /^(PK[0-9]{2})[A-Z0-9]{4}\d{16}$/, | ||
PL: /^(PL[0-9]{2})\d{24}$/, | ||
PS: /^(PS[0-9]{2})[A-Z0-9]{4}\d{21}$/, | ||
PT: /^(PT[0-9]{2})\d{21}$/, | ||
QA: /^(QA[0-9]{2})[A-Z]{4}[A-Z0-9]{21}$/, | ||
RO: /^(RO[0-9]{2})[A-Z]{4}[A-Z0-9]{16}$/, | ||
RS: /^(RS[0-9]{2})\d{18}$/, | ||
SA: /^(SA[0-9]{2})\d{2}[A-Z0-9]{18}$/, | ||
SC: /^(SC[0-9]{2})[A-Z]{4}\d{20}[A-Z]{3}$/, | ||
SE: /^(SE[0-9]{2})\d{20}$/, | ||
SI: /^(SI[0-9]{2})\d{15}$/, | ||
SK: /^(SK[0-9]{2})\d{20}$/, | ||
SM: /^(SM[0-9]{2})[A-Z]{1}\d{10}[A-Z0-9]{12}$/, | ||
TL: /^(TL[0-9]{2})\d{19}$/, | ||
TN: /^(TN[0-9]{2})\d{20}$/, | ||
TR: /^(TR[0-9]{2})\d{5}[A-Z0-9]{17}$/, | ||
UA: /^(UA[0-9]{2})\d{6}[A-Z0-9]{19}$/, | ||
VA: /^(VA[0-9]{2})\d{18}$/, | ||
VG: /^(VG[0-9]{2})[A-Z0-9]{4}\d{16}$/, | ||
XK: /^(XK[0-9]{2})\d{16}$/ | ||
}; | ||
/** | ||
* Check whether string has correct universal IBAN format | ||
* The IBAN consists of up to 34 alphanumeric characters, as follows: | ||
* Country Code using ISO 3166-1 alpha-2, two letters | ||
* check digits, two digits and | ||
* Basic Bank Account Number (BBAN), up to 30 alphanumeric characters. | ||
* NOTE: Permitted IBAN characters are: digits [0-9] and the 26 latin alphabetic [A-Z] | ||
* | ||
* @param {string} str - string under validation | ||
* @return {boolean} | ||
*/ | ||
|
||
function hasValidIbanFormat(str) { | ||
// Strip white spaces and hyphens, keep only digits and A-Z latin alphabetic | ||
var strippedStr = str.replace(/[^A-Z0-9]+/gi, '').toUpperCase(); | ||
var isoCountryCode = strippedStr.slice(0, 2).toUpperCase(); | ||
return isoCountryCode in ibanRegexThroughCountryCode && ibanRegexThroughCountryCode[isoCountryCode].test(strippedStr); | ||
} | ||
/** | ||
* Check whether string has valid IBAN Checksum | ||
* by performing basic mod-97 operation and | ||
* the remainder should equal 1 | ||
* -- Start by rearranging the IBAN by moving the four initial characters to the end of the string | ||
* -- Replace each letter in the string with two digits, A -> 10, B = 11, Z = 35 | ||
* -- Interpret the string as a decimal integer and | ||
* -- compute the remainder on division by 97 (mod 97) | ||
* Reference: https://en.wikipedia.org/wiki/International_Bank_Account_Number | ||
* | ||
* @param {string} str | ||
* @return {boolean} | ||
*/ | ||
|
||
|
||
function hasValidIbanChecksum(str) { | ||
var strippedStr = str.replace(/[^A-Z0-9]+/gi, '').toUpperCase(); // Keep only digits and A-Z latin alphabetic | ||
|
||
var rearranged = strippedStr.slice(4) + strippedStr.slice(0, 4); | ||
var alphaCapsReplacedWithDigits = rearranged.replace(/[A-Z]/g, function (char) { | ||
return char.charCodeAt(0) - 55; | ||
}); | ||
var remainder = alphaCapsReplacedWithDigits.match(/\d{1,7}/g).reduce(function (acc, value) { | ||
return Number(acc + value) % 97; | ||
}, ''); | ||
return remainder === 1; | ||
} | ||
|
||
function isIBAN(str) { | ||
(0, _assertString.default)(str); | ||
return hasValidIbanFormat(str) && hasValidIbanChecksum(str); | ||
} | ||
|
||
module.exports = exports.default; | ||
module.exports.default = exports.default; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,133 @@ | ||
import assertString from './util/assertString'; | ||
|
||
/** | ||
* List of country codes with | ||
* corresponding IBAN regular expression | ||
* Reference: https://en.wikipedia.org/wiki/International_Bank_Account_Number | ||
*/ | ||
const ibanRegexThroughCountryCode = { | ||
AD: /^(AD[0-9]{2})\d{8}[A-Z0-9]{12}$/, | ||
AE: /^(AE[0-9]{2})\d{3}\d{16}$/, | ||
AL: /^(AL[0-9]{2})\d{8}[A-Z0-9]{16}$/, | ||
AT: /^(AT[0-9]{2})\d{16}$/, | ||
AZ: /^(AZ[0-9]{2})[A-Z0-9]{4}\d{20}$/, | ||
BA: /^(BA[0-9]{2})\d{16}$/, | ||
BE: /^(BE[0-9]{2})\d{12}$/, | ||
BG: /^(BG[0-9]{2})[A-Z]{4}\d{6}[A-Z0-9]{8}$/, | ||
BH: /^(BH[0-9]{2})[A-Z]{4}[A-Z0-9]{14}$/, | ||
BR: /^(BR[0-9]{2})\d{23}[A-Z]{1}[A-Z0-9]{1}$/, | ||
BY: /^(BY[0-9]{2})[A-Z0-9]{4}\d{20}$/, | ||
CH: /^(CH[0-9]{2})\d{5}[A-Z0-9]{12}$/, | ||
CR: /^(CR[0-9]{2})\d{18}$/, | ||
CY: /^(CY[0-9]{2})\d{8}[A-Z0-9]{16}$/, | ||
CZ: /^(CZ[0-9]{2})\d{20}$/, | ||
DE: /^(DE[0-9]{2})\d{18}$/, | ||
DK: /^(DK[0-9]{2})\d{14}$/, | ||
DO: /^(DO[0-9]{2})[A-Z]{4}\d{20}$/, | ||
EE: /^(EE[0-9]{2})\d{16}$/, | ||
ES: /^(ES[0-9]{2})\d{20}$/, | ||
FI: /^(FI[0-9]{2})\d{14}$/, | ||
FO: /^(FO[0-9]{2})\d{14}$/, | ||
FR: /^(FR[0-9]{2})\d{10}[A-Z0-9]{11}\d{2}$/, | ||
GB: /^(GB[0-9]{2})[A-Z]{4}\d{14}$/, | ||
GE: /^(GE[0-9]{2})[A-Z0-9]{2}\d{16}$/, | ||
GI: /^(GI[0-9]{2})[A-Z]{4}[A-Z0-9]{15}$/, | ||
GL: /^(GL[0-9]{2})\d{14}$/, | ||
GR: /^(GR[0-9]{2})\d{7}[A-Z0-9]{16}$/, | ||
GT: /^(GT[0-9]{2})[A-Z0-9]{4}[A-Z0-9]{20}$/, | ||
HR: /^(HR[0-9]{2})\d{17}$/, | ||
HU: /^(HU[0-9]{2})\d{24}$/, | ||
IE: /^(IE[0-9]{2})[A-Z0-9]{4}\d{14}$/, | ||
IL: /^(IL[0-9]{2})\d{19}$/, | ||
IQ: /^(IQ[0-9]{2})[A-Z]{4}\d{15}$/, | ||
IS: /^(IS[0-9]{2})\d{22}$/, | ||
IT: /^(IT[0-9]{2})[A-Z]{1}\d{10}[A-Z0-9]{12}$/, | ||
JO: /^(JO[0-9]{2})[A-Z]{4}\d{22}$/, | ||
KW: /^(KW[0-9]{2})[A-Z]{4}[A-Z0-9]{22}$/, | ||
KZ: /^(KZ[0-9]{2})\d{3}[A-Z0-9]{13}$/, | ||
LB: /^(LB[0-9]{2})\d{4}[A-Z0-9]{20}$/, | ||
LC: /^(LC[0-9]{2})[A-Z]{4}[A-Z0-9]{24}$/, | ||
LI: /^(LI[0-9]{2})\d{5}[A-Z0-9]{12}$/, | ||
LT: /^(LT[0-9]{2})\d{16}$/, | ||
LU: /^(LU[0-9]{2})\d{3}[A-Z0-9]{13}$/, | ||
LV: /^(LV[0-9]{2})[A-Z]{4}[A-Z0-9]{13}$/, | ||
MC: /^(MC[0-9]{2})\d{10}[A-Z0-9]{11}\d{2}$/, | ||
MD: /^(MD[0-9]{2})[A-Z0-9]{20}$/, | ||
ME: /^(ME[0-9]{2})\d{18}$/, | ||
MK: /^(MK[0-9]{2})\d{3}[A-Z0-9]{10}\d{2}$/, | ||
MR: /^(MR[0-9]{2})\d{23}$/, | ||
MT: /^(MT[0-9]{2})[A-Z]{4}\d{5}[A-Z0-9]{18}$/, | ||
MU: /^(MU[0-9]{2})[A-Z]{4}\d{19}[A-Z]{3}$/, | ||
NL: /^(NL[0-9]{2})[A-Z]{4}\d{10}$/, | ||
NO: /^(NO[0-9]{2})\d{11}$/, | ||
PK: /^(PK[0-9]{2})[A-Z0-9]{4}\d{16}$/, | ||
PL: /^(PL[0-9]{2})\d{24}$/, | ||
PS: /^(PS[0-9]{2})[A-Z0-9]{4}\d{21}$/, | ||
PT: /^(PT[0-9]{2})\d{21}$/, | ||
QA: /^(QA[0-9]{2})[A-Z]{4}[A-Z0-9]{21}$/, | ||
RO: /^(RO[0-9]{2})[A-Z]{4}[A-Z0-9]{16}$/, | ||
RS: /^(RS[0-9]{2})\d{18}$/, | ||
SA: /^(SA[0-9]{2})\d{2}[A-Z0-9]{18}$/, | ||
SC: /^(SC[0-9]{2})[A-Z]{4}\d{20}[A-Z]{3}$/, | ||
SE: /^(SE[0-9]{2})\d{20}$/, | ||
SI: /^(SI[0-9]{2})\d{15}$/, | ||
SK: /^(SK[0-9]{2})\d{20}$/, | ||
SM: /^(SM[0-9]{2})[A-Z]{1}\d{10}[A-Z0-9]{12}$/, | ||
TL: /^(TL[0-9]{2})\d{19}$/, | ||
TN: /^(TN[0-9]{2})\d{20}$/, | ||
TR: /^(TR[0-9]{2})\d{5}[A-Z0-9]{17}$/, | ||
UA: /^(UA[0-9]{2})\d{6}[A-Z0-9]{19}$/, | ||
VA: /^(VA[0-9]{2})\d{18}$/, | ||
VG: /^(VG[0-9]{2})[A-Z0-9]{4}\d{16}$/, | ||
XK: /^(XK[0-9]{2})\d{16}$/, | ||
}; | ||
|
||
/** | ||
* Check whether string has correct universal IBAN format | ||
* The IBAN consists of up to 34 alphanumeric characters, as follows: | ||
* Country Code using ISO 3166-1 alpha-2, two letters | ||
* check digits, two digits and | ||
* Basic Bank Account Number (BBAN), up to 30 alphanumeric characters. | ||
* NOTE: Permitted IBAN characters are: digits [0-9] and the 26 latin alphabetic [A-Z] | ||
* | ||
* @param {string} str - string under validation | ||
* @return {boolean} | ||
*/ | ||
function hasValidIbanFormat(str) { | ||
// Strip white spaces and hyphens, keep only digits and A-Z latin alphabetic | ||
const strippedStr = str.replace(/[^A-Z0-9]+/gi, '').toUpperCase(); | ||
const isoCountryCode = strippedStr.slice(0, 2).toUpperCase(); | ||
|
||
return (isoCountryCode in ibanRegexThroughCountryCode) && | ||
ibanRegexThroughCountryCode[isoCountryCode].test(strippedStr); | ||
} | ||
|
||
/** | ||
* Check whether string has valid IBAN Checksum | ||
* by performing basic mod-97 operation and | ||
* the remainder should equal 1 | ||
* -- Start by rearranging the IBAN by moving the four initial characters to the end of the string | ||
* -- Replace each letter in the string with two digits, A -> 10, B = 11, Z = 35 | ||
* -- Interpret the string as a decimal integer and | ||
* -- compute the remainder on division by 97 (mod 97) | ||
* Reference: https://en.wikipedia.org/wiki/International_Bank_Account_Number | ||
* | ||
* @param {string} str | ||
* @return {boolean} | ||
*/ | ||
function hasValidIbanChecksum(str) { | ||
const strippedStr = str.replace(/[^A-Z0-9]+/gi, '').toUpperCase(); // Keep only digits and A-Z latin alphabetic | ||
const rearranged = strippedStr.slice(4) + strippedStr.slice(0, 4); | ||
const alphaCapsReplacedWithDigits = rearranged.replace(/[A-Z]/g, char => char.charCodeAt(0) - 55); | ||
|
||
const remainder = alphaCapsReplacedWithDigits.match(/\d{1,7}/g) | ||
.reduce((acc, value) => Number(acc + value) % 97, ''); | ||
|
||
return remainder === 1; | ||
} | ||
|
||
export default function isIBAN(str) { | ||
assertString(str); | ||
|
||
return hasValidIbanFormat(str) && hasValidIbanChecksum(str); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could make use of the ES6 features here for code succinctness if you don't mind, eg.
Same to line 133.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@profnandaa Thanks for your feedback! I'm already using ES6 features for code succinctness (i.e. arrow functions) in both of the locations you've pointed-out back in
src/lib/isIBAN.js
where the implementation lies, see here: https://github.com/validatorjs/validator.js/pull/1243/files#diff-ce49d7aaa9466099bb72b0307133b63dR121-R124the above file
lib/isIBAN.js
is auto-generated when running tests throughnpm test
, as the #CONTRIBUTING sections ofREADME.md
implies:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my bad. I reviewed the wrong part of code. You are right, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@profnandaa No problem! All is good 👍