Skip to content

fix(isInt, isFloat): Handle undefined and null values #2416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Daniyal-Qureshi
Copy link
Contributor

Enhanced both the 'isInt' and 'isFloat' functions by incorporating checks for null and undefined values, enabling them to handle cases where the input may be null or undefined

Issue Referenced

#2328

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@rubiin rubiin requested a review from profnandaa June 7, 2024 04:52
@rubiin rubiin added the ✅ LGTM label Jun 7, 2024
@Daniyal-Qureshi
Copy link
Contributor Author

Hi @profnandaa,
could you please review this PR.

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix! 🎉

@profnandaa profnandaa merged commit acdebd6 into validatorjs:master Jun 22, 2024
10 checks passed
@CptMaumau
Copy link

Hi @profnandaa will it be part of a release soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants