Skip to content

[CI] Use Ubuntu 24.04 image, more code coverage, disable CodeQL completely #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2024
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 22 additions & 28 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,9 @@ jobs:
- swift:5.7-jammy
- swift:5.8-jammy
- swift:5.9-jammy
- swift:5.10-jammy
- swift:5.10-noble
- swiftlang/swift:nightly-6.0-jammy
- swiftlang/swift:nightly-main-jammy
include:
- swift-image: swift:5.10-jammy
code-coverage: true
container: ${{ matrix.swift-image }}
runs-on: ubuntu-latest
steps:
Expand All @@ -40,12 +37,9 @@ jobs:
- name: Check out package
uses: actions/checkout@v4
- name: Run unit tests with Thread Sanitizer
env:
CODE_COVERAGE: ${{ matrix.code-coverage && '--enable-code-coverage' || '' }}
run: |
swift test --filter='^(PostgresNIOTests|ConnectionPoolModuleTests)' --sanitize=thread ${CODE_COVERAGE}
swift test --filter='^(PostgresNIOTests|ConnectionPoolModuleTests)' --sanitize=thread --enable-code-coverage
- name: Submit code coverage
if: ${{ matrix.code-coverage }}
uses: vapor/[email protected]
with:
codecov_token: ${{ secrets.CODECOV_TOKEN }}
Expand All @@ -66,7 +60,7 @@ jobs:
- postgres-image: postgres:12
postgres-auth: trust
container:
image: swift:5.10-jammy
image: swift:5.10-noble
volumes: [ 'pgrunshare:/var/run/postgresql' ]
runs-on: ubuntu-latest
env:
Expand Down Expand Up @@ -183,7 +177,7 @@ jobs:
api-breakage:
if: github.event_name == 'pull_request'
runs-on: ubuntu-latest
container: swift:jammy
container: swift:noble
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -195,21 +189,21 @@ jobs:
git config --global --add safe.directory "${GITHUB_WORKSPACE}"
swift package diagnose-api-breaking-changes origin/main

gh-codeql:
if: ${{ false }}
runs-on: ubuntu-latest
container: swift:jammy
permissions: { actions: write, contents: read, security-events: write }
steps:
- name: Check out code
uses: actions/checkout@v4
- name: Mark repo safe in non-fake global config
run: git config --global --add safe.directory "${GITHUB_WORKSPACE}"
- name: Initialize CodeQL
uses: github/codeql-action/init@v3
with:
languages: swift
- name: Perform build
run: swift build
- name: Run CodeQL analyze
uses: github/codeql-action/analyze@v3
# gh-codeql:
# if: ${{ false }}
# runs-on: ubuntu-latest
# container: swift:noble
# permissions: { actions: write, contents: read, security-events: write }
# steps:
# - name: Check out code
# uses: actions/checkout@v4
# - name: Mark repo safe in non-fake global config
# run: git config --global --add safe.directory "${GITHUB_WORKSPACE}"
# - name: Initialize CodeQL
# uses: github/codeql-action/init@v3
# with:
# languages: swift
# - name: Perform build
# run: swift build
# - name: Run CodeQL analyze
# uses: github/codeql-action/analyze@v3
Loading