-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create-next-app (canary): Import of *.module.scss in Client Component causes __webpack_require__.n is not a function
crash
#67783
Comments
WorkaroundIn speaking with @eps1lon, it appears that versions other than
|
Opened a PR to downgrade the App Router reproduction template to |
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change Closes NEXT- Fixes # --> ### What? Fix potential production compatibility problems with reproduction templates With the possibility of introducing `npx` problems (like what @samcx [fixed](#66301)) or other dev problems (like what [I reported](#67783)) ### Why? According to @eps1lon, versions other than `19.0.0-rc.0` can break in production ### How? Downgrade `react` and `react-dom` in App Router reproduction template to `19.0.0-rc.0`
Workaround proposed in #67673 |
@eps1lon thanks for the PR #67673, merge and publish in I've confirmed that this resolves the issue in my reproduction:
Here's the diff in the branch: |
Glad to hear. Thank you for confirming! |
This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Link to the code that reproduces this issue
https://github.com/karlhorky/repro-next-js-v15-react-rc-0-sass-webpack-require-not-a-function
To Reproduce
next dev
)/non-home
page⚠ Fast Refresh had to perform a full reload due to a runtime error.
warning in the terminal as seen in the video - you may need to repeat step 2 and 3 a few times to see the page-blocking warning):Kapture.2024-07-15.at.19.04.14.mp4
Reproduction setup steps
How the reproduction repo was created:
create-next-app
with TypeScript - adds[email protected]
and[email protected]
pnpm add sass
non-home/page.tsx
ClientComponent.tsx
andClientComponent.module.scss
with'use client'
<ClientComponent>
innon-home/page.tsx
/non-home
fromapp/page.tsx
usingnext/link
Current vs. Expected behavior
I expected no error when using
next/link
to navigate to a Client Component with a*.module.scss
import, but I observed an errorMaybe the
canary
template forcreate-next-app
needs to be updated to the[email protected]
and[email protected]
versionsWhile this demo does not crash with a page-blocking error very often (as seen in the video) more complicated apps crash consistently.
Provide environment information
Node.js v20.15.0 Operating System: Platform: darwin Arch: arm64 Version: Darwin Kernel Version 23.5.0: Wed May 1 20:16:51 PDT 2024; root:xnu-10063.121.3~5/RELEASE_ARM64_T8103 Available memory (MB): 16384 Available CPU cores: 8 Binaries: Node: 20.15.0 npm: 10.7.0 Yarn: N/A pnpm: 9.5.0 Relevant Packages: next: 15.0.0-canary.67 // Latest available version is detected (15.0.0-canary.67). eslint-config-next: N/A react: 19.0.0-rc.0 react-dom: 19.0.0-rc.0 typescript: 5.3.3 Next.js Config: output: N/A
Which area(s) are affected? (Select all that apply)
create-next-app, Navigation, Webpack
Which stage(s) are affected? (Select all that apply)
next dev (local)
Additional context
Updating to the
[email protected]
and[email protected]
versions as are in the App Router reproduction templateBut most users using
create-next-app@canary
will not know to do this.The text was updated successfully, but these errors were encountered: