Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page with a dynamic route can receive an incorrect params when deployed to Vercel #77789

Closed
ferrata opened this issue Apr 3, 2025 · 0 comments · Fixed by #77994
Closed

Page with a dynamic route can receive an incorrect params when deployed to Vercel #77789

ferrata opened this issue Apr 3, 2025 · 0 comments · Fixed by #77994
Labels
Dynamic Routes Related to dynamic routes.

Comments

@ferrata
Copy link

ferrata commented Apr 3, 2025

Link to the code that reproduces this issue

https://github.com/ferrata/nextjs-dynamic

To Reproduce

  1. Go to the test page
  2. The page shows params that were passed, and they are different from the expected:

Current vs. Expected behavior

The page should receive correct params:

{
  "locale": "en",
  "rest": [
    "folder",
    "page"
  ]
}

But instead receives incorrect params:

{
  "locale": "folder",
  "rest": [
    "page"
  ]
}

Provide environment information

Operating System:
  Platform: darwin
  Arch: arm64
  Version: Darwin Kernel Version 24.3.0: Thu Jan  2 20:24:16 PST 2025; root:xnu-11215.81.4~3/RELEASE_ARM64_T6000
  Available memory (MB): 16384
  Available CPU cores: 10
Binaries:
  Node: 18.20.2
  npm: 10.5.0
  Yarn: N/A
  pnpm: 9.15.4
Relevant Packages:
  next: 15.3.0-canary.31 // Latest available version is detected (15.3.0-canary.31).
  eslint-config-next: 15.2.4
  react: 19.1.0
  react-dom: 19.1.0
  typescript: 5.8.2
Next.js Config:
  output: N/A

Which area(s) are affected? (Select all that apply)

Dynamic Routes

Which stage(s) are affected? (Select all that apply)

Vercel (Deployed)

Additional context

Under certain conditions, for a page with dynamic route an incorrect params are passed to the page

The error is reproducing for me when the following conditions are met:

  • the page in question has a dynamic route
  • the parent route of the dynamic route has PPR (Partial Prerendering) enabled
  • a middleware is used to rewrite an original URL to patch a route (prepend a locale in my case)
  • the project is deployed on Vercel

Important

Note 1: The issue is not reproducible locally.

Important

Note 2: The parameters are passed correctly when navigating to the page from another route. The issue reproduces only when the page is loaded directly, or by refreshing the page.

@github-actions github-actions bot added the Dynamic Routes Related to dynamic routes. label Apr 3, 2025
wyattjoh added a commit that referenced this issue Apr 10, 2025
#77994)

When rendering the page on Vercel, we send the `x-matched-path` header
to indicate which route should be rendered. Sometimes, like in the case
of a middleware rewrite, we will rewrite a path to a statically
generated one. This results in a `x-matched-path` header being equal to
the generated page and not the route with the dynamic path params in it.

This ensures that if we get such a path that we match against that we do
save the result of the path matching as they are valid parameters.

This also fixes a related bug associated with route denormalization
which must occur before the routes i18n is parsed.

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->

Fixes #77789

---------

Co-authored-by: Jiwon Choi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dynamic Routes Related to dynamic routes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant