Skip to content

Added missing as propType to Link. #2579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2017
Merged

Added missing as propType to Link. #2579

merged 1 commit into from
Jul 17, 2017

Conversation

jaydenseric
Copy link
Contributor

This was causing the error Failed prop type: Link: unknown props found: as in Link when used with next-routes.

@jaydenseric
Added missing as propType to Link.
04862e2 
This was causing the error “Failed prop type: Link: unknown props found: as in Link” when used with next-routes.
@jaydenseric
Copy link
Contributor Author

At first I wondered if the Link API has changed, but it seems the as prop is still used. The as propType must have been missed when doing #2516? The issue seems fairly straightforward; I haven't tested this PR out locally via npm link.

@arunoda
Copy link
Contributor

arunoda commented Jul 17, 2017

Yeah! This is needed.

@arunoda arunoda merged commit 1a02b0e into vercel:v3-beta Jul 17, 2017
@timneutkens
Copy link
Member

Lol. #2571

@lock lock bot locked as resolved and limited conversation to collaborators Jul 17, 2018
@jaydenseric jaydenseric deleted the link-as-prop-type branch May 15, 2019 07:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaydenseric @arunoda @timneutkens