Skip to content

refactor(actions): untangle action-handler #75689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

refactor(actions): untangle action-handler #75689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
149572a
fix: dangling not-found returns
lubieowoce Feb 5, 2025
43a4869
no more returning undefined
lubieowoce Mar 5, 2025
44b1e3a
inline returns into branches
lubieowoce Mar 5, 2025
223874d
refactor: hoist codepaths for non-fetch actions out
lubieowoce Mar 6, 2025
58ff249
split "done" action result into two variants
lubieowoce Mar 6, 2025
99c1f06
extract non-fetch action handling and argument parsing into helpers
lubieowoce Mar 6, 2025
5c5aa6c
remove exception-based control flow for not-found and not-an-action
lubieowoce Mar 6, 2025
13d30ce
tighten up types for server action metadata
lubieowoce Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/next/errors.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,5 +659,11 @@
"658": "Pass `Infinity` instead of `false` if you want to cache on the server forever without checking with the origin.",
"659": "SSG should not return an image cache value",
"660": "Rspack support is only available in Next.js canary.",
"661": "Build failed because of %s errors"
"661": "Build failed because of %s errors",
"662": "Failed to find Server Action \"%s\". This request might be from an older or newer deployment.",
"663": "Failed to find Server Action \"%s\". This request might be from an older or newer deployment.%s",
"664": "Expected no-js actions to return from handler early.",
"665": "Expected actionId to be defined for a fetch action",
"666": "Action handler not found in action module",
"667": "This function cannot be used in the edge runtime"
}
Loading
Loading