Skip to content

Disable flaky Turbopack tests #76760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 6 additions & 35 deletions test/development/acceptance-app/ReactRefreshLogBox.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -344,22 +344,9 @@ describe('ReactRefreshLogBox app', () => {
)

if (isTurbopack) {
await expect(browser).toDisplayRedbox(`
{
"count": 1,
"description": "Error: ",
"environmentLabel": null,
"label": "Unhandled Runtime Error",
"source": "Child.js (4:11) @ ClickCount.render
> 4 | throw new Error()
| ^",
"stack": [
"ClickCount.render Child.js (4:11)",
"Home index.js (6:7)",
"<FIXME-file-protocol>",
],
}
`)
// TODO(veil): Turbopack is flaky. Possibly related to https://linear.app/vercel/issue/NDX-920/turbopack-errors-after-hmr-have-no-stacktraces-in-affected-chunks
// Should use `await expect(browser).toDisplayRedbox()`
await session.assertHasRedbox()
} else {
await expect(browser).toDisplayRedbox(`
{
Expand Down Expand Up @@ -1465,25 +1452,9 @@ describe('ReactRefreshLogBox app', () => {
await next.patchFile('index.js', "throw new Error('module error')")

if (isTurbopack) {
await expect(browser).toDisplayRedbox(`
{
"count": 1,
"description": "Error: module error",
"environmentLabel": null,
"label": "Runtime Error",
"source": "index.js (1:7) @ [project]/index.js [app-rsc] (ecmascript)
> 1 | throw new Error('module error')
| ^",
"stack": [
"[project]/index.js [app-rsc] (ecmascript) index.js (1:7)",
"[project]/app/server/page.js [app-rsc] (ecmascript) app/server/page.js (1:1)",
"<FIXME-file-protocol>",
"<FIXME-file-protocol>",
"<FIXME-file-protocol>",
"<FIXME-file-protocol>",
],
}
`)
// TODO(veil): Turbopack is flaky. Possibly related to https://linear.app/vercel/issue/NDX-920/turbopack-errors-after-hmr-have-no-stacktraces-in-affected-chunks
// Should use `await expect(browser).toDisplayRedbox()`
await session.assertHasRedbox()
} else {
await expect({ browser, next }).toDisplayRedbox(`
{
Expand Down
Loading