Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turbopack: charset=utf-8 in data-url source maps #77112

Merged
merged 1 commit into from
Mar 14, 2025
Merged

Turbopack: charset=utf-8 in data-url source maps #77112

merged 1 commit into from
Mar 14, 2025

Conversation

mischnic
Copy link
Contributor

@mischnic mischnic commented Mar 14, 2025 •
edited by padmaia
Loading

Previously, inline sourceMappingURL comments with data:application/json;charset=utf-8;base64,.... were just ignored, only data:application/json;base64,.... worked

Is there an easy way to test this?

Closes PACK-4145

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Mar 14, 2025
@mischnic Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mischnic mischnic requested a review from sokra March 14, 2025 10:11
@mischnic mischnic marked this pull request as ready for review March 14, 2025 10:12
@mischnic mischnic merged commit 03ce7f5 into canary Mar 14, 2025
129 of 130 checks passed
@mischnic mischnic deleted the mischnic/utf8-data-url-sourcemaps branch March 14, 2025 15:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mischnic @sokra @ijjk