[dev-overlay] Read issueCount from non-async errors array
#77821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves how we read the
issueCountproperty for the Next.js Dev Indicator. Data forruntimeErrorsis loaded in batches so the error count also jumps with it, but really we should be able to determine how many errors are going to be displayed before the data loads for all of them.Before the changes the issue count was very volatile, leading to UI jank as the errors data loads in:
CleanShot.2025-04-04.at.11.15.40.mp4
After the changes we still load the errors in batches, but the issue count is stable:
CleanShot.2025-04-04.at.11.15.25.mp4