The output tensor needs to be created on the same device as the query… #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tensor. Signed-off-by: ji-huazhong <[email protected]>
|
Looks like we should also fix this on main, would you mind cherry pick this? @ji-huazhong |
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Feb 21, 2025
vllm-project#54) ### What this PR does / why we need it? In open-r1, the rank 0 process will create an LLM instance and load the model to `npu:7`. We need to force the output tensor to be created on the same device as the query tensor. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Test by main branch Signed-off-by: angazenn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
In open-r1, the rank 0 process will create an LLM instance and load the model to
npu:7. We need to force the output tensor to be created on the same device as the query tensor.Does this PR introduce any user-facing change?
No
How was this patch tested?
Test by main branch