Skip to content

Commit 61acfc4

Browse files
authored
[Bugfix][Failing Test] Fix test_events.py (#18460)
Signed-off-by: rabi <[email protected]>
1 parent 107f5fc commit 61acfc4

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

.buildkite/test-pipeline.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,7 @@ steps:
138138
- vllm/core/
139139
- tests/distributed/test_utils
140140
- tests/distributed/test_pynccl
141+
- tests/distributed/test_events
141142
- tests/spec_decode/e2e/test_integration_dist_tp4
142143
- tests/compile/test_basic_correctness
143144
- examples/offline_inference/rlhf.py
@@ -156,6 +157,7 @@ steps:
156157
- pytest -v -s distributed/test_utils.py
157158
- pytest -v -s compile/test_basic_correctness.py
158159
- pytest -v -s distributed/test_pynccl.py
160+
- pytest -v -s distributed/test_events.py
159161
- pytest -v -s spec_decode/e2e/test_integration_dist_tp4.py
160162
# TODO: create a dedicated test section for multi-GPU example tests
161163
# when we have multiple distributed example tests

tests/distributed/test_events.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -119,13 +119,12 @@ def test_topic_filtering(publisher_config):
119119
"""
120120
publisher_config.replay_endpoint = None
121121

122-
cfg = publisher_config.model_copy()
123-
cfg.topic = "foo"
124-
pub = EventPublisherFactory.create(cfg)
122+
publisher_config.topic = "foo"
123+
pub = EventPublisherFactory.create(publisher_config)
125124

126125
from .conftest import MockSubscriber
127-
sub_foo = MockSubscriber(cfg.endpoint, None, "foo")
128-
sub_bar = MockSubscriber(cfg.endpoint, None, "bar")
126+
sub_foo = MockSubscriber(publisher_config.endpoint, None, "foo")
127+
sub_bar = MockSubscriber(publisher_config.endpoint, None, "bar")
129128

130129
try:
131130
time.sleep(0.1)

0 commit comments

Comments
 (0)