Skip to content

[Bugfix][Failing Test] Fix test_events.py #18460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025
Merged

Conversation

rabi
Copy link
Contributor

@rabi rabi commented May 21, 2025

Fixes tests/distributed/test_events.py::test_topic_filtering

FIX: #18458

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@markmc
Copy link
Member

markmc commented May 21, 2025

Thanks @rabi !

It looks like in #16750 we never added this new test to a CI job - could you find a suitable place for it in .buildkite/test-pipeline.yaml?

cc @alec-flowers

@markmc markmc added the ready ONLY add when PR is ready to merge/full CI is needed label May 21, 2025
Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok this bug stems from the fact that KVEventsConfig is no longer a pydantic.BaseModel (it was standardised to be a dataclass like the other configs).

The default scope of pytest.fixture is function (docs) so we should simply be able to remove the line cfg = publisher_config.model_copy(). Tests are allowed to mutate the fixture because it is not reused for multiple tests.

@rabi
Copy link
Contributor Author

rabi commented May 21, 2025

The default scope of pytest.fixture is function (docs)

done, Thanks!

@rabi rabi requested a review from hmellor May 21, 2025 09:18
@@ -156,6 +156,7 @@ steps:
- pytest -v -s distributed/test_utils.py
- pytest -v -s compile/test_basic_correctness.py
- pytest -v -s distributed/test_pynccl.py
- pytest -v -s distributed/test_events.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add this file to the source_file_dependencies above with test_utils and test_pynccl?

Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's see if the test suite passes

@hmellor hmellor enabled auto-merge (squash) May 21, 2025 10:10
@vllm-bot vllm-bot merged commit 61acfc4 into vllm-project:main May 21, 2025
75 of 94 checks passed
huachenheli pushed a commit to huachenheli/vllm that referenced this pull request May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Failing Test] : tests/distributed/test_events.py::test_topic_filtering - AttributeError: 'KVEventsConfig' object has no attribute 'model_copy'
4 participants