-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
[Bugfix][Failing Test] Fix test_events.py #18460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok this bug stems from the fact that KVEventsConfig
is no longer a pydantic.BaseModel
(it was standardised to be a dataclass
like the other configs).
The default scope of pytest.fixture
is function
(docs) so we should simply be able to remove the line cfg = publisher_config.model_copy()
. Tests are allowed to mutate the fixture because it is not reused for multiple tests.
done, Thanks! |
FIX: vllm-project#18458 Signed-off-by: rabi <[email protected]>
@@ -156,6 +156,7 @@ steps: | |||
- pytest -v -s distributed/test_utils.py | |||
- pytest -v -s compile/test_basic_correctness.py | |||
- pytest -v -s distributed/test_pynccl.py | |||
- pytest -v -s distributed/test_events.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add this file to the source_file_dependencies
above with test_utils
and test_pynccl
?
Signed-off-by: rabi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Let's see if the test suite passes
Signed-off-by: rabi <[email protected]> Signed-off-by: Chenheli Hua <[email protected]>
Fixes tests/distributed/test_events.py::test_topic_filtering
FIX: #18458