-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
[Bug]: make test_openai_schema.py
pass, enable it in CI
#18162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
bug
Something isn't working
Comments
davidxia
added a commit
to davidxia/vllm
that referenced
this issue
May 15, 2025
by filtering out test cases to `POST /tokenize` endpoint that are known to fail with a reply of HTTP 501 Not Implemented. Enable the test in CI. FIX vllm-project#18162 Signed-off-by: David Xia <[email protected]>
davidxia
added a commit
to davidxia/vllm
that referenced
this issue
May 16, 2025
by filtering out test cases to `POST /tokenize` endpoint that are known to fail with a reply of HTTP 501 Not Implemented. Enable the test in CI. FIX vllm-project#18162 Signed-off-by: David Xia <[email protected]>
davidxia
added a commit
to davidxia/vllm
that referenced
this issue
May 16, 2025
by filtering out test cases to `POST /tokenize` endpoint that are known to fail with a reply of HTTP 501 Not Implemented. Enable the test in CI. FIX vllm-project#18162 Signed-off-by: David Xia <[email protected]>
davidxia
added a commit
to davidxia/vllm
that referenced
this issue
May 20, 2025
by filtering out test cases to `POST /tokenize` endpoint that are known to fail with a reply of HTTP 501 Not Implemented. Enable the test in CI. FIX vllm-project#18162 Signed-off-by: David Xia <[email protected]>
davidxia
added a commit
to davidxia/vllm
that referenced
this issue
May 22, 2025
by filtering out test cases to `POST /tokenize` endpoint that are known to fail with a reply of HTTP 501 Not Implemented. Enable the test in CI. FIX vllm-project#18162 Signed-off-by: David Xia <[email protected]>
davidxia
added a commit
to davidxia/vllm
that referenced
this issue
May 22, 2025
by filtering out test cases to `POST /tokenize` endpoint that are known to fail with a reply of HTTP 501 Not Implemented. Enable the test in CI. FIX vllm-project#18162 Signed-off-by: David Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
This is a follow up to PR #17664 and issues like #17037 and #17038.
As of the time of this writing, the only sub-test in
tests/entrypoints/openai/test_openai_schema.py
that consistently fails isPOST /tokenize
caused byvllm/vllm/entrypoints/chat_utils.py
Line 1083 in 98ea356
part_type
is"file"
. The expected response is 200 as documented by the OpenAPI spec.How should we make this test pass? This is a requirement to eventually enabling the test in CI by removing
--ignore=entrypoints/openai/test_openai_schema.py
intest-pipeline.yaml
.Before submitting a new issue...
The text was updated successfully, but these errors were encountered: