-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
[Misc] Adding MMMU-Pro
vision dataset to serving benchmark
#10804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Roger Wang <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Co-authored-by: Chen Zhang <[email protected]> Signed-off-by: Roger Wang <[email protected]>
Note: Currently the serving benchmark does not correctly count the input image tokens, therefore the reported total token generation rate is not accurate. |
Signed-off-by: Roger Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM! I left a comment about dataset sampling, PTAL!
Co-authored-by: Isotr0py <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…oject#10804) Signed-off-by: Roger Wang <[email protected]> Co-authored-by: Chen Zhang <[email protected]> Co-authored-by: Isotr0py <[email protected]> Signed-off-by: Andrew Feldman <[email protected]>
…oject#10804) Signed-off-by: Roger Wang <[email protected]> Co-authored-by: Chen Zhang <[email protected]> Co-authored-by: Isotr0py <[email protected]>
…oject#10804) Signed-off-by: Roger Wang <[email protected]> Co-authored-by: Chen Zhang <[email protected]> Co-authored-by: Isotr0py <[email protected]>
This PR adds the support for MMMU-Pro vision dataset to the serving benchmark. This dataset is image-token-heavy (single image with average resolution of 1700x1600) and comes with a generic short text prompt, as describe in the dataset model card:
Example command to run the benchmark
Co-authored-by: @heheda12345