Skip to content

[Misc] Adding MMMU-Pro vision dataset to serving benchmark #10804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 1, 2024
Merged

[Misc] Adding MMMU-Pro vision dataset to serving benchmark #10804

merged 6 commits into from
Dec 1, 2024

Conversation

ywang96
Copy link
Member

@ywang96 ywang96 commented Dec 1, 2024

This PR adds the support for MMMU-Pro vision dataset to the serving benchmark. This dataset is image-token-heavy (single image with average resolution of 1700x1600) and comes with a generic short text prompt, as describe in the dataset model card:

Vision: In this subset, questions are embedded within screenshots or photos, and models must integrate visual and textual information to answer correctly. No separate text is fed into the model.

Example command to run the benchmark

vllm serve llava-hf/llava-v1.6-mistral-7b-hf

python3 benchmarks/benchmark_serving.py \
--dataset-path MMMU/MMMU_Pro \
--dataset-name hf \
--hf-subset "vision" \
--hf-split test \
--model llava-hf/llava-v1.6-mistral-7b-hf  \
--backend openai-chat \
--endpoint /v1/chat/completions \
--num-prompts 100

Co-authored-by: @heheda12345

Signed-off-by: Roger Wang <[email protected]>
Copy link

github-actions bot commented Dec 1, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Co-authored-by: Chen Zhang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
@ywang96
Copy link
Member Author

ywang96 commented Dec 1, 2024

Note: Currently the serving benchmark does not correctly count the input image tokens, therefore the reported total token generation rate is not accurate.

@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 1, 2024
Signed-off-by: Roger Wang <[email protected]>
Copy link
Collaborator

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! I left a comment about dataset sampling, PTAL!

ywang96 and others added 3 commits November 30, 2024 23:48
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Copy link
Collaborator

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Isotr0py Isotr0py enabled auto-merge (squash) December 1, 2024 08:07
@Isotr0py Isotr0py merged commit c11f172 into vllm-project:main Dec 1, 2024
28 checks passed
afeldman-nm pushed a commit to neuralmagic/vllm that referenced this pull request Dec 2, 2024
…oject#10804)

Signed-off-by: Roger Wang <[email protected]>
Co-authored-by: Chen Zhang <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
anko-intel pushed a commit to HabanaAI/vllm-fork that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants