Skip to content

[V1][VLM] Fix edge case bug for InternVL2 #11165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2024
Merged

[V1][VLM] Fix edge case bug for InternVL2 #11165

merged 2 commits into from
Dec 13, 2024

Conversation

ywang96
Copy link
Member

@ywang96 ywang96 commented Dec 13, 2024

When there's only one image in the batch, the image_embeds needs to be reshaped to [feature_size, hidden_size] from [num_patches, feature_size_per_patch, hidden_size] before getting unsqueezed.

This was previously not observed during offline mode because the default max_num_batched_tokens=8196 is always bigger than max image size of internVL2, but discovered when running online benchmark with the default max_num_batched_tokens=2048 where chunked prefill is needed.

Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@ywang96 ywang96 changed the title [V1] Fix edge case bug for InternVL2 [V1][VLM] Fix edge case bug for InternVL2 Dec 13, 2024
@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 13, 2024
@ywang96 ywang96 enabled auto-merge (squash) December 13, 2024 08:46
@ywang96 ywang96 merged commit 969da7d into vllm-project:main Dec 13, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants