Skip to content

Move linting to pre-commit #11975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 45 commits into from
Jan 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
7808d8e
Add pre-commit action
hmellor Jan 12, 2025
7185420
Move ruff, isort and yapf to pre-commit
hmellor Jan 12, 2025
426a423
Remove `--output-format github`
hmellor Jan 12, 2025
25d9f01
Remove now unneeded matcher
hmellor Jan 12, 2025
b9cff35
Move pymarkdownlnt to pre-commit
hmellor Jan 12, 2025
c1827bb
Move codespell to pre-commit
hmellor Jan 12, 2025
0d22cc3
Revert "Remove `--output-format github`"
hmellor Jan 12, 2025
87c8dd3
Limit ruff to same directories as format.sh
hmellor Jan 12, 2025
f8676bb
Add python version to pre-commit workflow
hmellor Jan 13, 2025
9cad2a2
Revert "Limit ruff to same directories as format.sh"
hmellor Jan 13, 2025
72b8daf
Move clang-format to pre-commit
hmellor Jan 13, 2025
83adeb0
Reorder hooks to match old format.sh order
hmellor Jan 13, 2025
fec3f0f
Move actionlint to pre-commit
hmellor Jan 13, 2025
f73e86c
test break action
hmellor Jan 13, 2025
ad07585
Add matcher for actionlint
hmellor Jan 13, 2025
4fff278
Allow typing.List because we support Python 3.8
hmellor Jan 13, 2025
1de5a70
Ignore other Python 3.8 typing rule
hmellor Jan 13, 2025
82fb8d2
Revert "test break action"
hmellor Jan 13, 2025
c279ead
Move mypy to pre-commit
hmellor Jan 13, 2025
2300c01
Move png-lint and shellcheck to pre-commit
hmellor Jan 13, 2025
2184d10
Fix syntax error in `.pre-commit-config.yaml`
hmellor Jan 13, 2025
37d5c00
Remove references to format.sh
hmellor Jan 13, 2025
c19a9ca
Remove unneeded args in pre-commit config
hmellor Jan 13, 2025
79c921f
Remove unneeded matrix
hmellor Jan 13, 2025
e765755
Make `clang-format` verbose
hmellor Jan 13, 2025
f0cef36
Make `yapf` verbose and exclude build dir
hmellor Jan 13, 2025
df4a08f
Revert ignoring new ruff rules
hmellor Jan 13, 2025
8e84156
Ignore Python 3.8 typing
hmellor Jan 13, 2025
8ecc505
Add `--toml` to codespell hook
hmellor Jan 13, 2025
deaf920
Add exclude to codespell hook
hmellor Jan 13, 2025
20552d8
Downgrade yapf
hmellor Jan 13, 2025
2ef6df2
Add missing dependency of yapf
hmellor Jan 13, 2025
6b8bb17
Downgrade ruff
hmellor Jan 13, 2025
b224f51
Downgrade clang-format
hmellor Jan 13, 2025
e3a4bfe
Remove png filter from shellcheck
hmellor Jan 13, 2025
1038df4
Limit clang-format to C++ and cuda
hmellor Jan 13, 2025
435f6ba
Run `clang-format`
hmellor Jan 13, 2025
7dad22b
Move mypy back into a matrix job to test python
hmellor Jan 13, 2025
d2e0ff7
Python versions to strings
hmellor Jan 13, 2025
15eed5a
Downgrade mypy and limit where it runs
hmellor Jan 13, 2025
0308ced
Call mypy from the script
hmellor Jan 13, 2025
d5edbb8
Capitalise mypy hook name
hmellor Jan 13, 2025
00adce3
Change to 1 `mypy` hook per Python version
hmellor Jan 16, 2025
c44e778
Add dummy checks to ease migration
hmellor Jan 17, 2025
da60064
Add matrix to dummy checks
hmellor Jan 17, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/nightly-benchmarks/scripts/nightly-annotate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ main() {



# The figures should be genereated by a separate process outside the CI/CD pipeline
# The figures should be generated by a separate process outside the CI/CD pipeline

# # generate figures
# python3 -m pip install tabulate pandas matplotlib
Expand Down
40 changes: 0 additions & 40 deletions .github/workflows/actionlint.yml

This file was deleted.

53 changes: 0 additions & 53 deletions .github/workflows/clang-format.yml

This file was deleted.

45 changes: 0 additions & 45 deletions .github/workflows/codespell.yml

This file was deleted.

32 changes: 0 additions & 32 deletions .github/workflows/doc-lint.yml

This file was deleted.

20 changes: 20 additions & 0 deletions .github/workflows/dummy.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: dummy-checks

on:
pull_request:

jobs:
mypy:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.12"]
steps:
- run: echo "This is a dummy step that always passes"
ruff:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.12"]
steps:
- run: echo "This is a dummy step that always passes"
17 changes: 0 additions & 17 deletions .github/workflows/matchers/ruff.json

This file was deleted.

51 changes: 0 additions & 51 deletions .github/workflows/mypy.yaml

This file was deleted.

37 changes: 0 additions & 37 deletions .github/workflows/png-lint.yml

This file was deleted.

17 changes: 17 additions & 0 deletions .github/workflows/pre-commit.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: pre-commit

on:
pull_request:
push:
branches: [main]

jobs:
pre-commit:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
with:
python-version: "3.12"
- run: echo "::add-matcher::.github/workflows/matchers/actionlint.json"
- uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd # v3.0.1
52 changes: 0 additions & 52 deletions .github/workflows/ruff.yml

This file was deleted.

Loading
Loading