Skip to content

[Core] Make disaggregated prefill compatible with pipeline parallelism #12301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

YuhanLiu11
Copy link

@YuhanLiu11 YuhanLiu11 commented Jan 22, 2025

This PR is part of the [RFC]: Disaggregated prefilling and KV cache transfer roadmap, which aims to make disaggregated prefill compatible with pipeline parallelism.

In pipeline parallelism, the intermediate hidden states transferred across different stages are stored in dictionaries. However, the current KV and intermediate transfer logic between prefill and decode instances only assumes these intermediate states are tensors.

This PR checks whether the hidden states transferred across P/D instances are dictionaries and, if so, sends the fields in these dictionaries separately.

Note: This current PR only makes disaggregated prefill compatible with pipeline parallelism in 1P1D setting (the pp degree in prefiller and decoder instances should be the same).

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link

This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you!

@github-actions github-actions bot added the stale Over 90 days of inactivity label Apr 23, 2025
Copy link

mergify bot commented Apr 23, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @YuhanLiu11.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Apr 23, 2025
@github-actions github-actions bot added unstale Recieved activity after being labelled stale and removed stale Over 90 days of inactivity labels Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase unstale Recieved activity after being labelled stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant