Skip to content

[Frontend] support AWS SageMaker inference id #12652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

bmuskalla
Copy link

@bmuskalla bmuskalla commented Feb 1, 2025

In order to improve support for running vLLM on AWS Sagemaker,
take their HTTP header into account for tracking inference requests. In addition to X-Request-Id, consider X-Amzn-SageMaker-Inference-Id as well in those cases. Header is documented here https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_runtime_InvokeEndpoint.html#API_runtime_InvokeEndpoint_RequestSyntax

Signed-off-by: Benjamin Muskalla <[email protected]>
Copy link

github-actions bot commented Feb 1, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added documentation Improvements or additions to documentation frontend labels Feb 1, 2025
@bmuskalla
Copy link
Author

Build failure seem to be
a) unrelated FAILED tests/tpu/test_custom_dispatcher.py::test_custom_dispatcher - AttributeError: 'NoneType' object has no attribute '__setitem__'. Did you mean: '__setattr__'?
b) transient ReadTimeoutError("HTTPSConnectionPool(host='huggingface.co', port=443):

@bmuskalla bmuskalla closed this Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant