Skip to content

Filter out unsupported arch list instead of error #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Filter out unsupported arch list instead of error #1280

wants to merge 2 commits into from

Conversation

yunfeng-scale
Copy link
Contributor

@yunfeng-scale yunfeng-scale commented Oct 7, 2023 •
edited
Loading

Fixes #1225

it's unclear to me why we want to throw error rather than just filter out the unsupported architectures.

@yunfeng-scale yunfeng-scale mentioned this pull request Oct 7, 2023
Merged
@DRL36
Copy link

DRL36 commented Oct 11, 2023

@WoosukKwon @zhuohan123 Hi, i'm facing exactly same bug here. Can we merge this soon?

@WoosukKwon
Copy link
Collaborator

Hi @yunfeng-scale, thanks for submitting the PR. However, I believe we should raise an error rather than silently filtering out the unsupported architecture. This is because TORCH_ARCH_LIST is usually something user intentionally specified.

@yunfeng-scale
Copy link
Contributor Author

Hi @yunfeng-scale, thanks for submitting the PR. However, I believe we should raise an error rather than silently filtering out the unsupported architecture. This is because TORCH_ARCH_LIST is usually something user intentionally specified.

Sounds good. Although I want to point out in docker images like nvcr.io/nvidia/pytorch:22.12-py3 TORCH_ARCH_LIST is specified in the image and not all appear in SUPPORTED_ARCHS. People may get confused when they try to build using their Dockerfile and see errors like #1225

@yunfeng-scale
Copy link
Contributor Author

closing since the original PR #1239 takes the stance of filtering + printing warnings.

pi314ever pushed a commit to pi314ever/vllm that referenced this pull request May 20, 2025
@adobrzyn
WA for CI - pkg resources (vllm-project#1280)
c86b560 
WA for:
Error: vllm/executor/ray_distributed_executor.py:554: error: Library
stubs not installed for "pkg_resources" [import-untyped]

---------

Signed-off-by: Agata Dobrzyniewicz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installation Error
3 participants
@yunfeng-scale @DRL36 @WoosukKwon