Skip to content

[Doc]: Improve feature tables #13224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 18, 2025
Merged

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Feb 13, 2025

  • Use ❌ and ❔ instead of ASCII characters
  • Replace some ❌ with ✅ if features are now supported/compatible
  • Add vertical-table-header CSS class to make "Feature x Feature" table more readable:
    image

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Feb 13, 2025
@hmellor hmellor marked this pull request as ready for review February 13, 2025 17:35
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
@DarkLight1337
Copy link
Member

cc @mgoin @robertgshaw2-redhat to confirm the updates to other feature compatibilities.

@DarkLight1337
Copy link
Member

Perhaps we should use a different symbol for partial support?

@hmellor
Copy link
Member Author

hmellor commented Feb 17, 2025

Sure, that sounds like a good idea

@DarkLight1337
Copy link
Member

Can you also use this for multi-modal + prefix caching?

Signed-off-by: Harry Mellor <[email protected]>
@DarkLight1337
Copy link
Member

The multimodal part LGTM

Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, the quantization table looks good to me. FYI we had to use the crappy ascii check and cross before because of RST support issues. Now that we are in markdown, I'm glad we can use nice looking emojis :)

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 18, 2025 09:50
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 18, 2025
@youkaichao youkaichao disabled auto-merge February 18, 2025 10:52
@youkaichao youkaichao merged commit 2358ca5 into vllm-project:main Feb 18, 2025
24 of 28 checks passed
@hmellor hmellor deleted the improve-feature-table branch February 18, 2025 10:55
xjpang pushed a commit to xjpang/vllm that referenced this pull request Feb 20, 2025
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants