Skip to content

[bugfix] spec decode worker get tp group only when initialized #13578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2025
Merged

[bugfix] spec decode worker get tp group only when initialized #13578

merged 2 commits into from
Feb 20, 2025

Conversation

simon-mo
Copy link
Collaborator

@simon-mo simon-mo commented Feb 20, 2025 •
edited by github-actions bot
Loading

Fix issue in #13269

@simon-mo simon-mo mentioned this pull request Feb 20, 2025
Merged
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@simon-mo
fix imports
076bb5b 
Signed-off-by: simon-mo <[email protected]>
@simon-mo simon-mo added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 20, 2025
youkaichao
youkaichao approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@simon-mo simon-mo enabled auto-merge (squash) February 20, 2025 04:29
@simon-mo simon-mo merged commit 8c755c3 into vllm-project:main Feb 20, 2025
57 checks passed
xjpang pushed a commit to xjpang/vllm that referenced this pull request Feb 20, 2025
@simon-mo
[bugfix] spec decode worker get tp group only when initialized (vllm-…
1c4b1e7 
…project#13578)
@houseroad
Copy link
Collaborator

thanks for fixing this.

Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
@simon-mo @Akshat-Tripathi
[bugfix] spec decode worker get tp group only when initialized (vllm-…
82a666b 
…project#13578)
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@simon-mo @lulmer
[bugfix] spec decode worker get tp group only when initialized (vllm-…
57e87e4 
…project#13578)

Signed-off-by: Louis Ulmer <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@simon-mo @shreyankg
[bugfix] spec decode worker get tp group only when initialized (vllm-…
d1c9e96 
…project#13578)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youkaichao youkaichao youkaichao approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed speculative-decoding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simon-mo @houseroad @youkaichao