Skip to content

docs: Add documentation for s390x cpu implementation #14198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 11, 2025
Merged

docs: Add documentation for s390x cpu implementation #14198

merged 6 commits into from
Mar 11, 2025

Conversation

dilipgb
Copy link
Contributor

@dilipgb dilipgb commented Mar 4, 2025

This PR provides documentation for building vLLM cpu implementation for s390x architecture. PR for s390x cpu implementation is approved and awaiting merge. #12613

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Mar 4, 2025
@dilipgb
Copy link
Contributor Author

dilipgb commented Mar 6, 2025

@dtrifiro can you please take a look at this PR.

hmellor
hmellor approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a docs perspective, this looks good to me.

Only suggestion is to make sure torchvision doesn't have a space.

@mergify Mergify
Copy link

mergify bot commented Mar 11, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @dilipgb.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Mar 11, 2025
@dilipgb dilipgb closed this Mar 11, 2025
@dilipgb dilipgb reopened this Mar 11, 2025
@mergify mergify bot removed the needs-rebase label Mar 11, 2025
dilipgb and others added 4 commits March 11, 2025 16:22
@dilipgb
docs: Documentation for s390x cpu builds
695dfe6 
Signed-off-by: Dilip Gowda Bhagavan <[email protected]>
@dilipgb
chore: cleanup contents
85f9e52 
Signed-off-by: Dilip Gowda Bhagavan <[email protected]>
@dilipgb
chore: correct the typo in s390x docs
f36081d 
Signed-off-by: Dilip Gowda Bhagavan <[email protected]>
@dilipgb @hmellor
Apply suggestions from code review
05551b3 
Co-authored-by: Harry Mellor <[email protected]>
Signed-off-by: Dilip Gowda Bhagavan <[email protected]>
@dilipgb
Copy link
Contributor Author

dilipgb commented Mar 11, 2025

@hmellor, I have rebased the PR and updated installation.md with path changes due to rebase. Also addressed whitespace in torchvision. Can we merge the PR, if this looks good?

@hmellor hmellor enabled auto-merge (squash) March 11, 2025 16:07
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 11, 2025
@hmellor hmellor merged commit 07964e2 into vllm-project:main Mar 11, 2025
26 checks passed
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Mar 11, 2025
@dilipgb @hmellor @JC1DA
docs: Add documentation for s390x cpu implementation (vllm-project#14198
51516bd 
)

Signed-off-by: Dilip Gowda Bhagavan <[email protected]>
Co-authored-by: Harry Mellor <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@dilipgb @hmellor @lulmer
docs: Add documentation for s390x cpu implementation (vllm-project#14198
8ffebd3 
)

Signed-off-by: Dilip Gowda Bhagavan <[email protected]>
Co-authored-by: Harry Mellor <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
nishith-fujitsu pushed a commit to nishith-fujitsu/vllm that referenced this pull request Apr 9, 2025
@dilipgb @hmellor @nishith-fujitsu
docs: Add documentation for s390x cpu implementation (vllm-project#14198
8c2722e 
)

Signed-off-by: Dilip Gowda Bhagavan <[email protected]>
Co-authored-by: Harry Mellor <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@dilipgb @hmellor @shreyankg
docs: Add documentation for s390x cpu implementation (vllm-project#14198
4855edf 
)

Signed-off-by: Dilip Gowda Bhagavan <[email protected]>
Co-authored-by: Harry Mellor <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@dilipgb @hmellor
docs: Add documentation for s390x cpu implementation (vllm-project#14198
b9eaa0d 
)

Signed-off-by: Dilip Gowda Bhagavan <[email protected]>
Co-authored-by: Harry Mellor <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmellor hmellor hmellor approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dilipgb @hmellor