-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
[Bugfix][V1] Fix flashinfer sampling #14815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix][V1] Fix flashinfer sampling #14815
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the PR!
Hi @WoosukKwon @DefTruth , it should be easy to switch to the new API, maybe @xslingcn can help create a new PR for the new API? |
Signed-off-by: Louis Ulmer <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
small fix base on #14788
Currently, we have errors when using FlashInfer>=v0.2.3 for top-p & top-k sampling. As a workaround, we disable FlashInfer for top-p & top-k sampling by default while FlashInfer>=v0.2.3. The sampling API removes the success return value of all sampling API, which is not compatible with earlier design. reference: https://github.com/flashinfer-ai/flashinfer/releases/tag/v0.2.3