-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
[Misc] Upgrade BNB version #15183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] Upgrade BNB version #15183
Conversation
Signed-off-by: Jee Jee Li <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
@@ -284,7 +284,7 @@ RUN --mount=type=cache,target=/root/.cache/uv \ | |||
if [ "$TARGETPLATFORM" = "linux/arm64" ]; then \ | |||
uv pip install accelerate hf_transfer 'modelscope!=1.15.0' 'bitsandbytes>=0.42.0' 'timm==0.9.10' boto3 runai-model-streamer runai-model-streamer[s3]; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgoin Not sure if this BNB also needs to be upgraded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess is yes, but I haven't tested it. In any case since it is just raising the floor there shouldn't be an issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: bitsandbytes does not support linux aarch64 yet, but it's on our backlog!
Signed-off-by: Wes Medford <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
After upgrading PyTorch to 2.6, BNB also needs to be forcibly upgraded to 0.45.3