Skip to content

Fix Transformers backend compatibility check #15290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2025
Merged

Fix Transformers backend compatibility check #15290

merged 2 commits into from
Mar 31, 2025

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Mar 21, 2025 •
edited
Loading

Prerequisites:

Explanation:

  • is_backend_compatible is a method that all PreTrainedModel will have
  • flex attention is an arbitratry attention interface that shouldn't determine compatibility

cc @ArthurZucker

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

ArthurZucker
ArthurZucker reviewed Mar 21, 2025
View reviewed changes
Copy link
Contributor

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I don't remember if is_backend_compatible was in 4.49 or not... time flies

@hmellor
Copy link
Member Author

hmellor commented Mar 21, 2025

Ah good point, looks like this is another one to add to the stack on top of #13905

@ariG23498 ariG23498 mentioned this pull request Mar 24, 2025
Merged
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 27, 2025 02:01
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 27, 2025
@hmellor hmellor disabled auto-merge March 27, 2025 09:03
@hmellor
Copy link
Member Author

hmellor commented Mar 27, 2025

Disabling auto merge because the function used is only guaranteed to exist after transformers 4.49 (so the linked PR must merge first)

ArthurZucker
ArthurZucker reviewed Mar 31, 2025
View reviewed changes
Copy link
Contributor

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@hmellor hmellor enabled auto-merge (squash) March 31, 2025 16:08
@DarkLight1337 DarkLight1337 disabled auto-merge March 31, 2025 16:26
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 31, 2025 16:26
@DarkLight1337
Copy link
Member

Merging since basic model tests have passed

@vllm-bot vllm-bot merged commit d4bfc23 into vllm-project:main Mar 31, 2025
30 of 36 checks passed
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Apr 2, 2025
@hmellor @kylesayrs
Fix Transformers backend compatibility check (vllm-project#15290)
96c6825 
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@hmellor @Alex4210987
Fix Transformers backend compatibility check (vllm-project#15290)
60ea10e 
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: xinyuxiao <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@hmellor @lulmer
Fix Transformers backend compatibility check (vllm-project#15290)
14c4498 
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
nishith-fujitsu pushed a commit to nishith-fujitsu/vllm that referenced this pull request Apr 9, 2025
@hmellor @nishith-fujitsu
Fix Transformers backend compatibility check (vllm-project#15290)
34b1db2 
Signed-off-by: Harry Mellor <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
@hmellor hmellor deleted the fix-transformers-compatibility-check branch April 24, 2025 16:21
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@hmellor @lk-chen
Fix Transformers backend compatibility check (vllm-project#15290)
01e0f0e 
Signed-off-by: Harry Mellor <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@hmellor @shreyankg
Fix Transformers backend compatibility check (vllm-project#15290)
1247674 
Signed-off-by: Harry Mellor <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@hmellor
Fix Transformers backend compatibility check (vllm-project#15290)
e3ec43a 
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurZucker ArthurZucker ArthurZucker left review comments

@aarnphm aarnphm aarnphm approved these changes

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hmellor @DarkLight1337 @aarnphm @ArthurZucker @vllm-bot