Skip to content

[V1][Core] Remove unused speculative config from scheduler #15818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2025
Merged

[V1][Core] Remove unused speculative config from scheduler #15818

merged 1 commit into from
Mar 31, 2025

Conversation

markmc
Copy link
Member

@markmc markmc commented Mar 31, 2025 •
edited by github-actions bot
Loading

This was introduced in #12193 but was unused even then

/cc @LiuXiaoxuanPKU @WoosukKwon

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Mar 31, 2025
@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) March 31, 2025 17:32
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 31, 2025
@robertgshaw2-redhat robertgshaw2-redhat merged commit f98a492 into vllm-project:main Mar 31, 2025
43 checks passed
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Apr 2, 2025
@markmc @kylesayrs
[V1][Core] Remove unused speculative config from scheduler (vllm-proj…
3ed2f12 
…ect#15818)

Signed-off-by: Mark McLoughlin <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@markmc @Alex4210987
[V1][Core] Remove unused speculative config from scheduler (vllm-proj…
e3fad0d 
…ect#15818)

Signed-off-by: Mark McLoughlin <[email protected]>
Signed-off-by: xinyuxiao <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@markmc @lulmer
[V1][Core] Remove unused speculative config from scheduler (vllm-proj…
b08d157 
…ect#15818)

Signed-off-by: Mark McLoughlin <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
nishith-fujitsu pushed a commit to nishith-fujitsu/vllm that referenced this pull request Apr 9, 2025
@markmc @nishith-fujitsu
[V1][Core] Remove unused speculative config from scheduler (vllm-proj…
9fabf10 
…ect#15818)

Signed-off-by: Mark McLoughlin <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@markmc @lk-chen
[V1][Core] Remove unused speculative config from scheduler (vllm-proj…
6fb7f38 
…ect#15818)

Signed-off-by: Mark McLoughlin <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@markmc @shreyankg
[V1][Core] Remove unused speculative config from scheduler (vllm-proj…
679bb79 
…ect#15818)

Signed-off-by: Mark McLoughlin <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@markmc
[V1][Core] Remove unused speculative config from scheduler (vllm-proj…
9e9aded 
…ect#15818)

Signed-off-by: Mark McLoughlin <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertgshaw2-redhat robertgshaw2-redhat robertgshaw2-redhat approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markmc @robertgshaw2-redhat