Skip to content

[Misc][Benchmark] Remove colon from key 'request_goodput:' #16018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

appleparan
Copy link

@appleparan appleparan commented Apr 3, 2025

Rename key 'request_goodput:' to 'request_goodput' in the benchmark code.

This is a simple mistypo fix. Unlike other metrics, correct behavior where the metric name was not being mapped in result_json correctly due to the colon in 'request_goodput:'.

Unlike other metrics, fixed an issue where the metric name was not being mapped in result_json correctly due to the colon in 'request_goodput:'

Signed-off-by: Jongsu Liam Kim <[email protected]>
Copy link

github-actions bot commented Apr 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@appleparan appleparan changed the title [Misc] Remove colon from key 'request_goodput:' [Misc][Benchmark] Remove colon from key 'request_goodput:' Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant