Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] improve chat_with_tools example #16044

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

reidliu41
Copy link
Contributor

@reidliu41 reidliu41 commented Apr 4, 2025

  • add tips for fist-time, the example models need to apply the access permission
  • handle the first json output if got the prefix
    e.g.
[TOOL_CALLS][{"name": "get_current_weather", "arguments": {"city": "Dallas", "state": "TX", "unit": "fahrenheit"}}]
Traceback (most recent call last):
  File "/home/examples/offline_inference/chat_with_tools.py", line 134, in <module>
    tool_funtions[call['name']](**call['arguments']) for call in tool_calls
                                                                 ^^^^^^^^^^
NameError: name 'tool_calls' is not defined
  • enhance the json parse handling
  • add some debug messages

Copy link

github-actions bot commented Apr 4, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Apr 4, 2025
@DarkLight1337 DarkLight1337 requested a review from mgoin April 6, 2025 08:21
})
except json.JSONDecodeError:
print(
"\n\033[91mJSON parsing failed, the model returned non-structured content:\033[0m\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have the rich library in the test dependencies. Perhaps it would be better to use that to output colored text because hopefully it will detect whether stdout can handle colors or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants