-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix]: Dockerfile.ppc64le fixes for opencv-python and hf-xet #16048
base: main
Are you sure you want to change the base?
[fix]: Dockerfile.ppc64le fixes for opencv-python and hf-xet #16048
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
20c8e34
to
0fc52a2
Compare
@DarkLight1337 could you please enable ppc64le specific tests for this PR to have them verified? |
Hmm. @khluu I think you need to enable this over at https://github.com/vllm-project/buildkite-ci |
@khluu @DarkLight1337 is the build/test for ppc64le enabled for this PR? |
c199879
to
b2e8362
Compare
Unblocking ppc64le test. Sorry for the delay! |
cc @khluu why are the scripts missing from the CI? |
I think this branch is stale (it was created when the script was not moved yet). Can you rebase this branch with main? |
b2e8362
to
97264b7
Compare
I've unblocked the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if the test passes
It failed, but because of Triton this time, rather than because of hf_xet. @Shafi-Hussain do you want to fix that in this PR or in a follow up? |
Hi @hmellor, I'd prefer to have it fixed in this PR itself. Could we please hold off on merging for a while? Also, if you could share which exact step failed, it would be helpful to debug. Triton should not have been built for ppc64le builds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'll change the review so that the merge button cannot be pressed.
You can see the logs in https://buildkite.com/vllm/ci/builds/17352/steps?jid=01961f98-719f-47a7-b20a-04d69d7ad280
|
@hmellor can we have this PR merged? Since the triton conflicts have been resolved |
Can you rebase so that we can run the test again to verify that this fix works? |
…from source Signed-off-by: Md. Shafi Hussain <[email protected]>
Removing pinned setuptools version Signed-off-by: Md. Shafi Hussain <[email protected]>
97264b7
to
7172e72
Compare
Test unblocked and running here |
Test failed, this time seemingly because of |
Signed-off-by: Md. Shafi Hussain <[email protected]>
@hmellor fixed the errors. It doesn't seem like the ppc64le build got triggered. Could you please check and confirm? |
Changes: