Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix][TPU] Fix V1 TPU worker for sliding window #16059

Merged
merged 1 commit into from
Apr 4, 2025
Merged

[Bugfix][TPU] Fix V1 TPU worker for sliding window #16059

merged 1 commit into from
Apr 4, 2025

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Apr 4, 2025

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added v1 tpu Related to Google TPUs labels Apr 4, 2025
@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) April 4, 2025 18:52
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 4, 2025
@mgoin mgoin mentioned this pull request Apr 4, 2025
Merged
yaochengji
yaochengji approved these changes Apr 4, 2025
View reviewed changes
Copy link
Collaborator

@yaochengji yaochengji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this.

@robertgshaw2-redhat robertgshaw2-redhat merged commit 70ad3f9 into vllm-project:main Apr 4, 2025
62 checks passed
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@mgoin @Alex4210987
[Bugfix][TPU] Fix V1 TPU worker for sliding window (vllm-project#16059)
5d20912 
Signed-off-by: Michael Goin <[email protected]>
Signed-off-by: xinyuxiao <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@mgoin @lulmer
[Bugfix][TPU] Fix V1 TPU worker for sliding window (vllm-project#16059)
e55a619 
Signed-off-by: Michael Goin <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
nishith-fujitsu pushed a commit to nishith-fujitsu/vllm that referenced this pull request Apr 9, 2025
@mgoin @nishith-fujitsu
[Bugfix][TPU] Fix V1 TPU worker for sliding window (vllm-project#16059)
26d8ad4 
Signed-off-by: Michael Goin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaochengji yaochengji yaochengji approved these changes

@robertgshaw2-redhat robertgshaw2-redhat robertgshaw2-redhat approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed tpu Related to Google TPUs v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgoin @yaochengji @robertgshaw2-redhat