Skip to content

[TPU][V1][DEBUG] Provide Env Variable To Disable Sampler #16063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

NickLucche
Copy link
Contributor

@NickLucche NickLucche commented Apr 4, 2025

Just continuing @robertgshaw2-redhat work from #15662.
This should be ready, let's wait for tests to confirm it.

cc @yaochengji

Copy link

github-actions bot commented Apr 4, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@NickLucche NickLucche changed the title [TPU][DEBUG] Provide Env Variable To Disable Sampler [TPU][V1][DEBUG] Provide Env Variable To Disable Sampler Apr 4, 2025
@mergify mergify bot added v1 tpu Related to Google TPUs labels Apr 4, 2025
@yaochengji yaochengji added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 4, 2025
@NickLucche
Copy link
Contributor Author

As always, thanks for reviewing!

Copy link
Collaborator

@yaochengji yaochengji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link

mergify bot commented Apr 8, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @NickLucche.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Apr 8, 2025
robertgshaw2-redhat and others added 4 commits April 8, 2025 14:32
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
@NickLucche NickLucche force-pushed the tpu-disable-sampler-var branch from 50a00ad to 0d71400 Compare April 8, 2025 14:56
@mergify mergify bot removed the needs-rebase label Apr 8, 2025
@NickLucche
Copy link
Contributor Author

closing in favor of #16275

@NickLucche NickLucche closed this Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed tpu Related to Google TPUs v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants