[Bugfix][V1] Merge multimodal embeddings by index instead of matching tokens #16229
+24
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a mismatch in merging multi-modal embeddings when the model itself generates embedding placeholder tokens such as
<image>
. Although this error mainly occurs in V1, it can possibly occur in V0 as well. This PR focuses on the V1 case.For V0 users, you can work around this by setting
top_p
so that the model has no chance of generating such tokens.FIX #14897
FIX #15677
FIX #15764