Skip to content

[Bugfix][V1] Merge multimodal embeddings by index instead of matching tokens #16229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Apr 8, 2025

This PR fixes a mismatch in merging multi-modal embeddings when the model itself generates embedding placeholder tokens such as <image>. Although this error mainly occurs in V1, it can possibly occur in V0 as well. This PR focuses on the V1 case.

For V0 users, you can work around this by setting top_p so that the model has no chance of generating such tokens.

FIX #14897
FIX #15677
FIX #15764

Copy link

github-actions bot commented Apr 8, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added v1 tpu Related to Google TPUs labels Apr 8, 2025
@DarkLight1337 DarkLight1337 changed the title [Bugfix] Merge multimodal embeddings by mask instead of token ID [Bugfix][V1] Merge multimodal embeddings by mask instead of token ID Apr 8, 2025
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 changed the title [Bugfix][V1] Merge multimodal embeddings by mask instead of token ID [Bugfix][V1] Merge multimodal embeddings by index instead of token ID Apr 8, 2025
@DarkLight1337 DarkLight1337 changed the title [Bugfix][V1] Merge multimodal embeddings by index instead of token ID [Bugfix][V1] Merge multimodal embeddings by index instead of matching token ID Apr 8, 2025
@DarkLight1337 DarkLight1337 changed the title [Bugfix][V1] Merge multimodal embeddings by index instead of matching token ID [Bugfix][V1] Merge multimodal embeddings by index instead of matching tokens Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tpu Related to Google TPUs v1
Projects
Status: In Progress
1 participant