-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
[TPU][V1] Enable Top-P #16843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TPU][V1] Enable Top-P #16843
Conversation
Signed-off-by: NickLucche <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
Can you merge from main to fix CI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution!
Signed-off-by: NickLucche <[email protected]> Co-authored-by: mgoin <[email protected]> Signed-off-by: dtransposed <damian@damian-ml-machine.europe-west3-b.c.jetbrains-grazie.internal>
Signed-off-by: NickLucche <[email protected]> Co-authored-by: mgoin <[email protected]> Signed-off-by: Frieda (Jingying) Huang <[email protected]>
Signed-off-by: NickLucche <[email protected]> Co-authored-by: mgoin <[email protected]> Signed-off-by: Zijing Liu <[email protected]>
Signed-off-by: NickLucche <[email protected]> Co-authored-by: mgoin <[email protected]>
Signed-off-by: NickLucche <[email protected]> Co-authored-by: mgoin <[email protected]>
Signed-off-by: NickLucche <[email protected]> Co-authored-by: mgoin <[email protected]>
Signed-off-by: NickLucche <[email protected]> Co-authored-by: mgoin <[email protected]>
Signed-off-by: NickLucche <[email protected]> Co-authored-by: mgoin <[email protected]> Signed-off-by: Agata Dobrzyniewicz <[email protected]>
Signed-off-by: NickLucche <[email protected]> Co-authored-by: mgoin <[email protected]> Signed-off-by: Mu Huai <[email protected]>
Follow up to #15489.
This PR enables the work done #15736.
We split up the contribs to better monitor performance as described more in detail here #16268.
Here's the benchmark I ran on single chip with and without top-p:
Benchmark commands
Performance is looking good here. We should probably run a larger sweep just to be safe.
PS: performance with/without topk/p sampling-params (eg setting only temperature=0.2) is virtually identical as the graph being executed is the same. This is not the case when all requests in the batch have temperature=0 (all_greedy).
cc @hyeygit