Skip to content

[Doc] Split dummy_processor_inputs() in Multimodal Docs #16915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2025
Merged

[Doc] Split dummy_processor_inputs() in Multimodal Docs #16915

merged 2 commits into from
Apr 21, 2025

Conversation

alex-jw-brooks
Copy link
Contributor

@alex-jw-brooks alex-jw-brooks commented Apr 21, 2025 •
edited
Loading

This PR follows #16416 with some doc changes for implementing get_dummy_mm_data & get_dummy_text instead of get_dummy_processor_inputs, since multimodal models should now implement these directly! @DarkLight1337

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Apr 21, 2025
DarkLight1337
DarkLight1337 approved these changes Apr 21, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I forgot about this. Thanks for updating the docs!

@DarkLight1337 DarkLight1337 mentioned this pull request Apr 21, 2025
Closed
57 tasks
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 21, 2025 10:19
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 21, 2025
@DarkLight1337 DarkLight1337 merged commit b34f334 into vllm-project:main Apr 21, 2025
28 of 31 checks passed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@alex-jw-brooks @yangw-dev
[Doc] Split dummy_processor_inputs() in Multimodal Docs (vllm-project…
18c2d9e 
…#16915)

Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
dtransposed pushed a commit to dtransposed/vllm that referenced this pull request Apr 22, 2025
@alex-jw-brooks
[Doc] Split dummy_processor_inputs() in Multimodal Docs (vllm-project…
fcaf5d7 
…#16915)

Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: dtransposed <damian@damian-ml-machine.europe-west3-b.c.jetbrains-grazie.internal>
frieda-huang pushed a commit to frieda-huang/vllm that referenced this pull request Apr 23, 2025
@alex-jw-brooks @frieda-huang
[Doc] Split dummy_processor_inputs() in Multimodal Docs (vllm-project…
1aabca0 
…#16915)

Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Frieda (Jingying) Huang <[email protected]>
liuzijing2014 pushed a commit to liuzijing2014/vllm that referenced this pull request Apr 25, 2025
@alex-jw-brooks @liuzijing2014
[Doc] Split dummy_processor_inputs() in Multimodal Docs (vllm-project…
c43b185 
…#16915)

Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Zijing Liu <[email protected]>
liuzijing2014 pushed a commit to liuzijing2014/vllm that referenced this pull request Apr 25, 2025
@alex-jw-brooks @liuzijing2014
[Doc] Split dummy_processor_inputs() in Multimodal Docs (vllm-project…
6eac49a 
…#16915)

Signed-off-by: Alex-Brooks <[email protected]>
wuisawesome pushed a commit to character-tech/vllm that referenced this pull request Apr 28, 2025
@alex-jw-brooks @wuisawesome
[Doc] Split dummy_processor_inputs() in Multimodal Docs (vllm-project…
1c25c63 
…#16915)

Signed-off-by: Alex-Brooks <[email protected]>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@alex-jw-brooks @dbyoung18
[Doc] Split dummy_processor_inputs() in Multimodal Docs (vllm-project…
415732a 
…#16915)

Signed-off-by: Alex-Brooks <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@alex-jw-brooks @lk-chen
[Doc] Split dummy_processor_inputs() in Multimodal Docs (vllm-project…
9ebcea3 
…#16915)

Signed-off-by: Alex-Brooks <[email protected]>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@alex-jw-brooks @adobrzyn
[Doc] Split dummy_processor_inputs() in Multimodal Docs (vllm-project…
dc3fa43 
…#16915)

Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Agata Dobrzyniewicz <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@alex-jw-brooks
[Doc] Split dummy_processor_inputs() in Multimodal Docs (vllm-project…
f21b203 
…#16915)

Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex-jw-brooks @DarkLight1337