Skip to content

[Security] Fix image hash collision #17378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2025
Merged

[Security] Fix image hash collision #17378

merged 2 commits into from
May 2, 2025

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Apr 29, 2025 •
edited by github-actions bot
Loading

@DarkLight1337 DarkLight1337 added ready ONLY add when PR is ready to merge/full CI is needed security Security related issues and PRs labels Apr 29, 2025
@DarkLight1337 DarkLight1337 requested a review from russellb April 29, 2025 10:36
@DarkLight1337 DarkLight1337 requested a review from ywang96 as a code owner April 29, 2025 10:36
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the multi-modality Related to multi-modality (#4194) label Apr 29, 2025
@DarkLight1337
Fix more cases
261502a 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 added this to the v0.9.0 milestone Apr 30, 2025
russellb
russellb approved these changes May 2, 2025
View reviewed changes
Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed by @kexinoh in GHSA-c65p-x677-fgj6, as well.

Thank you for adding the tests!

@russellb russellb merged commit 99404f5 into vllm-project:main May 2, 2025
42 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-hash-collision branch May 2, 2025 12:36
radeksm pushed a commit to radeksm/vllm that referenced this pull request May 2, 2025
@DarkLight1337 @radeksm
[Security] Fix image hash collision (vllm-project#17378)
b3ddc26 
Signed-off-by: DarkLight1337 <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@DarkLight1337
[Security] Fix image hash collision (vllm-project#17378)
9c65121 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@DarkLight1337 @mawong-amd
[Security] Fix image hash collision (vllm-project#17378)
aa506d3 
Signed-off-by: DarkLight1337 <[email protected]>
@tiran tiran mentioned this pull request May 19, 2025
Open
1 task
@lgeiger lgeiger mentioned this pull request May 19, 2025
Merged
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@DarkLight1337
[Security] Fix image hash collision (vllm-project#17378)
a762c9a 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russellb russellb russellb approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

Assignees
No one assigned
Labels
multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed security Security related issues and PRs
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DarkLight1337 @russellb