Skip to content

[BugFix] Increase timeout for startup failure test #17642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2025

Conversation

njhill
Copy link
Member

@njhill njhill commented May 5, 2025

This test is now failing on main most of the time due to the timeout not being large enough.

I'm still confused why this started failing recently. The problem is that just creating VllmConfig takes 10 seconds before we even create the LLM, which is due to the model class being loaded in a separate process to be able to read some config from it:

def inspect_model_cls(self) -> _ModelInfo:
return _run_in_subprocess(
lambda: _ModelInfo.from_model_cls(self.load_model_cls()))
def load_model_cls(self) -> Type[nn.Module]:
mod = importlib.import_module(self.module_name)
return getattr(mod, self.class_name)

It would be good if we could find a way to retrieve the info in question (like is_multimodal_model) without this overhead - I assume it's adding to startup time in all cases, cumulatively contributing to CI times quite a bit, etc.

@njhill njhill added the bug Something isn't working label May 5, 2025
Copy link

github-actions bot commented May 5, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label May 5, 2025
@DarkLight1337
Copy link
Member

DarkLight1337 commented May 5, 2025

@hmellor maybe this is related to the recent config refactor? Another possibility is that the overall import time of vLLM has increased significantly for whatever reason.

The code related to retrieving model info has been here for many months already, so that by itself couldn't be the cause. This code exists to get around CUDA re-initialization error because importing the model files may initialize CUDA before vLLM Engine is started.

Copy link
Collaborator

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for short mitigation. Maybe we can create an issue for tracking this? Sounds like a good ramp up task?

@hmellor
Copy link
Member

hmellor commented May 5, 2025

From this profile we can see that the actual retrieval of the model only takes about 1s (bottom thread) but the overhead of creating the new process for is_multimodal_model is unusually large (10s, as @njhill originally said)

image

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's unblock CI first. We can solve the underlying problem later

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 5, 2025 09:05
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 5, 2025
@DarkLight1337 DarkLight1337 merged commit 5ea5c51 into vllm-project:main May 5, 2025
31 checks passed
@njhill njhill deleted the fix-startup-timeout-test branch May 5, 2025 21:16
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants