Skip to content

[Bugfix] fix an illegal memory access was encountered of marlin kernel + act_order #18245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 16, 2025

Conversation

jinzhen-lin
Copy link
Contributor

Fix #18147

Signed-off-by: Jinzhen Lin <[email protected]>
Signed-off-by: Jinzhen Lin <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: Jinzhen Lin <[email protected]>
Signed-off-by: Jinzhen Lin <[email protected]>
@mgoin mgoin added bug Something isn't working ready ONLY add when PR is ready to merge/full CI is needed labels May 16, 2025
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, LGTM! Let's see if CI is green

@mgoin mgoin added this to the v0.9.0 milestone May 16, 2025
@jinzhen-lin
Copy link
Contributor Author

@mgoin The failed tests seems unrelated. Quantization test also failed on main branch. https://buildkite.com/vllm/ci/builds/20197#0196d740-afa9-4124-acdf-c971cdf483f2

@simon-mo simon-mo merged commit e73b7df into vllm-project:main May 16, 2025
98 of 101 checks passed
@DarkLight1337
Copy link
Member

This PR is breaking LoRA Tests 4. It wasn't failing on the previous PR on main

@jinzhen-lin
Copy link
Contributor Author

This PR is breaking LoRA Tests 4. It wasn't failing on the previous PR on main

It seems that the LoRA tests are passed after retry https://buildkite.com/vllm/ci/builds/20254 . This PR does nothing to lora, and the previous failed model is not a quantized model, so it may not related to this PR.

@DarkLight1337
Copy link
Member

I see, thanks for the info. I'll keep an eye out for further failres then.

@DarkLight1337
Copy link
Member

On the other hand, a bunch of distributed tests are failing on this PR. They are still failing after retrying them.

@jinzhen-lin
Copy link
Contributor Author

On the other hand, a bunch of distributed tests are failing on this PR. They are still failing after retrying them.

Very strange. All failed models are not quantized models. And those failed tests are passed again after two commits https://buildkite.com/vllm/ci/builds/20259 . No idea now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants