-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
[Bugfix] fix an illegal memory access was encountered
of marlin kernel + act_order
#18245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jinzhen Lin <[email protected]>
Signed-off-by: Jinzhen Lin <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Jinzhen Lin <[email protected]>
Signed-off-by: Jinzhen Lin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, LGTM! Let's see if CI is green
@mgoin The failed tests seems unrelated. Quantization test also failed on main branch. https://buildkite.com/vllm/ci/builds/20197#0196d740-afa9-4124-acdf-c971cdf483f2 |
This PR is breaking LoRA Tests 4. It wasn't failing on the previous PR on main |
It seems that the LoRA tests are passed after retry https://buildkite.com/vllm/ci/builds/20254 . This PR does nothing to lora, and the previous failed model is not a quantized model, so it may not related to this PR. |
I see, thanks for the info. I'll keep an eye out for further failres then. |
On the other hand, a bunch of distributed tests are failing on this PR. They are still failing after retrying them. |
Very strange. All failed models are not quantized models. And those failed tests are passed again after two commits https://buildkite.com/vllm/ci/builds/20259 . No idea now. |
…nel + act_order (vllm-project#18245) Signed-off-by: Chenheli Hua <[email protected]>
…nel + act_order (vllm-project#18245) Signed-off-by: Yuqi Zhang <[email protected]>
Fix #18147