Skip to content

Update common.txt #18442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update common.txt #18442

wants to merge 1 commit into from

Conversation

jerryzh168
Copy link
Contributor

Adding torchao as a common dep

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label May 20, 2025
@jerryzh168
Update common.txt
16fe271 
Signed-off-by: Jerry Zhang <[email protected]>
luccafong
luccafong approved these changes May 21, 2025
View reviewed changes
Copy link
Collaborator

@luccafong luccafong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@DarkLight1337
Copy link
Member

cc @mgoin we don't usually include quantization libraries (e.g. bitsandbytes) in our common dependencies.

@jerryzh168
Copy link
Contributor Author

I see, is there a better location?

houseroad
houseroad reviewed May 27, 2025
View reviewed changes
requirements/common.txt
@@ -47,3 +47,4 @@ opentelemetry-sdk>=1.26.0 # vllm.tracing
opentelemetry-api>=1.26.0 # vllm.tracing
opentelemetry-exporter-otlp>=1.26.0 # vllm.tracing
opentelemetry-semantic-conventions-ai>=0.4.1 # vllm.tracing
torchao == 0.11.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we use >= 0.11.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like no good place to add this, seems like other quant libraries are not added, so I plan to drop this PR for now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just in tets:

vllm/requirements/test.in

Line 42 in a09c7ca

bitsandbytes>=0.45.3
,

vllm/requirements/test.txt

Line 44 in a09c7ca

bitsandbytes==0.45.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houseroad houseroad houseroad left review comments

@luccafong luccafong luccafong approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ci/build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jerryzh168 @DarkLight1337 @houseroad @luccafong