Skip to content

[V1] fix torch profiling for V1 offline scenarios #18445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

divakar-amd
Copy link
Contributor

@divakar-amd divakar-amd commented May 21, 2025

Currently, the torch profiler doesn't capture anything useful for V1 offline benchmarking scenarios as the gpu_worker is attached to a different process.  This PR:

  1. Refactors offline benchmarking scripts to capture profiler information for both V0 & V1 mode.
  2. Dumps kernels summary table automatically when the profiler is stopped.
  • The PR replaces --profile-result-dir and checks if the VLLM_TORCH_PROFILER_DIR environment variable is set before enabling profiling

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label May 21, 2025
Signed-off-by: Divakar Verma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant