Skip to content

Reshape cache flash kernel to support HND layout #8200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

wenscarl
Copy link
Contributor

@wenscarl wenscarl commented Sep 5, 2024

NHD: [num_blocks, block_size, num_heads, head_size]
HND: [num_blocks, num_heads, block_size, head_size]
Many fast attention kernels only support HND layout for kv_cache and this PR make reshape_and_cache_flash kernel support both.

@wenscarl wenscarl marked this pull request as draft September 5, 2024 16:19
Copy link

github-actions bot commented Sep 5, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@wenscarl wenscarl force-pushed the reshape_cache_to_xqa_compatible branch from 76b2706 to 7df8e91 Compare September 5, 2024 18:06
@wenscarl wenscarl marked this pull request as ready for review September 5, 2024 19:39
@WoosukKwon
Copy link
Collaborator

👀

Copy link

mergify bot commented Nov 5, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. @wenscarl please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Nov 5, 2024
@wenscarl wenscarl changed the title Reshape cache to be XQA kernel compatible Reshape cache flash kernel to support HND layout Nov 5, 2024
@mergify mergify bot removed the needs-rebase label Nov 5, 2024
@wenscarl wenscarl force-pushed the reshape_cache_to_xqa_compatible branch from 86c54bc to 36245ed Compare November 8, 2024 16:22
Copy link

This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you!

@github-actions github-actions bot added the stale Over 90 days of inactivity label Feb 25, 2025
Copy link

mergify bot commented Feb 25, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @wenscarl.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 25, 2025
@github-actions github-actions bot added unstale Recieved activity after being labelled stale and removed stale Over 90 days of inactivity labels Feb 26, 2025
@wenscarl wenscarl force-pushed the reshape_cache_to_xqa_compatible branch from 44f6b58 to c845f81 Compare March 30, 2025 16:47
@mergify mergify bot removed the needs-rebase label Mar 30, 2025
@wenscarl
Copy link
Contributor Author

@WoosukKwon could you review the changes? Thanks!

@wenscarl wenscarl force-pushed the reshape_cache_to_xqa_compatible branch from c845f81 to 492d7d8 Compare March 30, 2025 17:06
@wenscarl wenscarl force-pushed the reshape_cache_to_xqa_compatible branch from d3fbb2b to 193e637 Compare April 8, 2025 19:12
@wenscarl wenscarl requested a review from tlrmchlsmth April 8, 2025 19:13
@wenscarl wenscarl force-pushed the reshape_cache_to_xqa_compatible branch 2 times, most recently from 5db863e to 19548ab Compare April 14, 2025 04:39
@wenscarl wenscarl force-pushed the reshape_cache_to_xqa_compatible branch from 19548ab to 7f538d7 Compare April 14, 2025 04:41
Signed-off-by: shuw <[email protected]>
Signed-off-by: shuw <[email protected]>
@wenscarl wenscarl force-pushed the reshape_cache_to_xqa_compatible branch from 7f538d7 to dd2613f Compare April 16, 2025 15:00
Copy link

mergify bot commented Apr 23, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @wenscarl.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase unstale Recieved activity after being labelled stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants