Set torch default dtype in a context manager #971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antoni Baum <[email protected]>
|
cc @zhuohan123 @WoosukKwon lmk if this makes sense! |
WoosukKwon
approved these changes
Sep 7, 2023
wanmok
pushed a commit
to wanmok/vllm
that referenced
this pull request
Sep 7, 2023
Signed-off-by: Antoni Baum <[email protected]>
|
This commit breaks PagedAttentionWithALiBi, where the bias from set_attn_bias is initialized to a wrong dtype, causing |
liuyanyi
pushed a commit
to liuyanyi/vllm
that referenced
this pull request
Sep 12, 2023
Signed-off-by: Antoni Baum <[email protected]>
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
Signed-off-by: Antoni Baum <[email protected]>
pi314ever
pushed a commit
to pi314ever/vllm
that referenced
this pull request
Apr 3, 2025
vLLM Llama3.1-70B FP8 2K/2K throughput measurements shows good improvement with blocksize 256 , hence adding this as an option to the argument list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifying the global state is unexpected and can lead to issues later (regarding eg. precision or when testing).