This repository was archived by the owner on Mar 31, 2022. It is now read-only.
Support .pairs in the user's HOME directory, as advertised.
#26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…list of ancestor directories. This is preparation for further work.
This fixes the actual behavior to match the documentation, which states that the `.pairs` file may be in the user's home directory.
|
I've been hit by this bug twice in the last week. Really happy to see someone fixing it! The original logic for looking up the directory was ... certainly unique, but I can't say I'm sad to see it go. |
Closed
ragaskar
added a commit
that referenced
this pull request
Dec 16, 2014
Support `.pairs` in the user's HOME directory, as advertised.
|
:highfive: |
|
In 1.4.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README file states that a
.pairsfile may be "in project root or your home folder." This isn't true unless the working directory is under the user's home directory.This PR contains two commits: one to slightly clean up the directory-search logic; and then a second to implement the addition of the user's home directory to the end of the search path.