Skip to content

Correct config for prometheus_monitoring #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
LongLiveCHIEF opened this issue Apr 9, 2018 · 0 comments
Open

Correct config for prometheus_monitoring #212

LongLiveCHIEF opened this issue Apr 9, 2018 · 0 comments
Assignees
@LongLiveCHIEF
Labels
enhancement New feature or request
Milestone
Gitlab HA Support

Comments

@LongLiveCHIEF
Copy link
Contributor

LongLiveCHIEF commented Apr 9, 2018 •
edited
Loading

The parameter for prometheus_monitoring_enable should be just prometheus_monitoring. Reasons include:

  • consistency in usage and admin expectations
  • it's not just a simple true/false scenario, due to implicit defaults for both single-server and ha role handling scenarios
  • inflexibility if gitlab adds more supported attributes for this config
@LongLiveCHIEF LongLiveCHIEF added the enhancement New feature or request label Apr 9, 2018
@LongLiveCHIEF LongLiveCHIEF self-assigned this Apr 9, 2018
@LongLiveCHIEF LongLiveCHIEF changed the title Add support for monitoring configs in gitlab.rb.erb (prometheus, node exporters, etc..) Correct config for prometheus_monitoring Apr 11, 2018
@LongLiveCHIEF LongLiveCHIEF added this to the Gitlab HA Support milestone Apr 11, 2018
tjcomputer92 pushed a commit to tjcomputer92/puppet-gitlab that referenced this issue Oct 30, 2019
voxpupuli#212 fixing prometheus module
378b3ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LongLiveCHIEF LongLiveCHIEF

Labels
enhancement New feature or request
Projects
None yet
Milestone
Gitlab HA Support
Development

No branches or pull requests
1 participant
@LongLiveCHIEF