Skip to content

Please fix support of Red Hat Software Collection versions #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Please fix support of Red Hat Software Collection versions #266

wants to merge 2 commits into from

Conversation

iakovgan
Copy link
Contributor

Support of Red Hat Software Collection was broken with validation of python::version variable.

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: validate_re(): "python27" does not match ["system", "pypy", "3"] at .... /modules/python/manifests/init.pp:98 on node [NODE]

This pull request fixes this issue.

@shivapoudel
Copy link
Contributor

Fix the travis-ci builds ;)

@iakovgan
Copy link
Contributor Author

iakovgan commented Dec 6, 2015

I for me it is ok: is something else broken?

[root@vm puppet-python]# bundle exec metadata-json-lint metadata.json && bundle exec rake validate && bundle exec rake lint && SPEC_OPTS="--format documentation" bundle exec rake spec
...
Finished in 20.65 seconds (files took 2.65 seconds to load)
83 examples, 0 failures

BTW do not merge now. SCL support is broken much harder than i thought and was not tested for a long time. Working on a fix.

Please help me to pass travis my patch is inrelevant to the test.

@iakovgan
Copy link
Contributor Author

iakovgan commented Dec 6, 2015

I withdraw this PR. SLC support needs a bigger fix. #270 is a good candidate but will need an update of documentation and fix of python::pip .

@iakovgan iakovgan closed this Dec 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants