Skip to content

Use the correct type on $service_limits #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2017

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Nov 22, 2017

Closes GH-49

@raphink
Copy link
Member

raphink commented Nov 22, 2017

Why not adapt Systemd::ServiceLimits instead?

@ekohl
Copy link
Member Author

ekohl commented Nov 22, 2017

This calls create_resources on the systemd::service_limits defined type. That has a parameter limits with the Systemd::ServiceLimits which does the actual checks.

@raphink
Copy link
Member

raphink commented Nov 22, 2017

Ah, that makes sense. LGTM then.

@bastelfreak bastelfreak added the enhancement New feature or request label Nov 22, 2017
@bastelfreak
Copy link
Member

Thanks for the PR @ekohl

@bastelfreak bastelfreak merged commit 7f20f58 into voxpupuli:master Nov 22, 2017
@ekohl ekohl deleted the fix-service-limits branch November 22, 2017 19:48
@ekohl
Copy link
Member Author

ekohl commented Nov 22, 2017

@bastelfreak I'd say this is a bugfix rather than an enhancement. Before the parameter was unusable.

@bastelfreak bastelfreak added bug and removed enhancement New feature or request labels Nov 22, 2017
op-ct pushed a commit to op-ct/puppet-systemd that referenced this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants